Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: don't publish pretty-format/perf to npm #9612

Merged
merged 1 commit into from
Feb 25, 2020

Conversation

thymikee
Copy link
Collaborator

@thymikee thymikee commented Feb 25, 2020

Summary

No need to publish perf directory from pretty-format. 106KB less to download by consumers.

Before -> After:

npm notice package size:  170.2 kB -> 64.1 kB
npm notice unpacked size: 526.6 kB -> 263.9 kB

Test plan

npm pack

Copy link
Contributor

@jeysal jeysal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 👍 👍

@codecov-io
Copy link

Codecov Report

Merging #9612 into master will increase coverage by 0.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #9612      +/-   ##
==========================================
+ Coverage   65.09%   65.11%   +0.01%     
==========================================
  Files         287      287              
  Lines       12145    12145              
  Branches     3007     3009       +2     
==========================================
+ Hits         7906     7908       +2     
+ Misses       3604     3603       -1     
+ Partials      635      634       -1
Impacted Files Coverage Δ
packages/expect/src/utils.ts 96.22% <0%> (+1.25%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2ee214d...9b1d5d8. Read the comment docs.

@thymikee thymikee merged commit 003bd50 into jestjs:master Feb 25, 2020
@thymikee thymikee deleted the chore/pretty-format-publish-less branch February 25, 2020 15:09
@github-actions
Copy link

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.
Please note this issue tracker is not a help forum. We recommend using StackOverflow or our discord channel for questions.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 11, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants