Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use the new serializer plugin API in example #9847

Merged
merged 1 commit into from Apr 26, 2020
Merged

Conversation

Andarist
Copy link
Contributor

According to pretty-format docs the new API has been introduced in Jest 21 but the main docs still mention only the old API (I wasn't actually able to find any reference to the new API).

@@ -840,7 +840,7 @@ module.exports = {
};
```

`serialize` is a function that serializes a value using existing plugins.
`printer` is a function that serializes a value using existing plugins.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

where does this printer name come from?

Copy link
Contributor Author

@Andarist Andarist Apr 20, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Member

@SimenB SimenB left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Andarist
Copy link
Contributor Author

@SimenB good idea, I've added such link

docs/Configuration.md Outdated Show resolved Hide resolved
Copy link
Member

@SimenB SimenB left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

If you could update the versioned docs as well, that'd be lovely 🙏

@codecov-io
Copy link

Codecov Report

Merging #9847 into master will decrease coverage by 0.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #9847      +/-   ##
==========================================
- Coverage   64.49%   64.47%   -0.02%     
==========================================
  Files         289      289              
  Lines       12333    12333              
  Branches     3051     3051              
==========================================
- Hits         7954     7952       -2     
- Misses       3740     3741       +1     
- Partials      639      640       +1     
Impacted Files Coverage Δ
packages/expect/src/utils.ts 94.96% <0.00%> (-1.26%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 470ef2d...9b94381. Read the comment docs.

@Andarist
Copy link
Contributor Author

If you could update the versioned docs as well, that'd be lovely 🙏

which versions should I update? only the current one? or do you want to go back with this change up to Jest 21?

@SimenB
Copy link
Member

SimenB commented Apr 25, 2020

I don't think we have back to 21, but all we have would be great 👍

@Andarist
Copy link
Contributor Author

Andarist commented Apr 26, 2020

@SimenB I've applied those changes on all versioned docs

Copy link
Member

@SimenB SimenB left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank you!

@SimenB SimenB merged commit 4a142ec into jestjs:master Apr 26, 2020
jeysal added a commit to mmkal/jest that referenced this pull request Apr 28, 2020
…pshots

* runtime-require-resolve-outside:
  lint
  review improvements
  implement require.resolve option outsideJestVm for internal modules only
  basic jest-runtime require.resolve test
  Fix dead link to coverage CLI option (jestjs#9905)
  chore: remove dated node 6 reference from docs (jestjs#9895)
  Use the new serializer plugin API in example (jestjs#9847)
  chore: remove unused catch clauses (jestjs#9893)
@github-actions
Copy link

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.
Please note this issue tracker is not a help forum. We recommend using StackOverflow or our discord channel for questions.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 11, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants