Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Doesn’t work with new many‐recording‐releases #29

Closed
Freso opened this issue Jan 28, 2015 · 10 comments
Closed

Doesn’t work with new many‐recording‐releases #29

Freso opened this issue Jan 28, 2015 · 10 comments
Labels
mb_MASS-MERGE-RECORDINGS server change
Milestone
2015

Comments

@Freso
Copy link
Contributor

Freso commented Jan 28, 2015

E.g., merging recordings from https://beta.musicbrainz.org/release/5231db37-3b4a-43d3-af15-1f524a35f147 to https://beta.musicbrainz.org/release/e815a245-4e64-46df-8413-fe7983673f13 (currently only on beta, but will go live on production at next release - or earlier, as it may get included in a hotfix)
@jesus2099
Copy link
Owner

Thanks Freso,
It seems INLINE STUFF is broken too.
I wonder what’s up with those releases… do you know a ticket link so I could roughly understand what was done (I guess either the layout changed or the tracklist rendering was delayed).

@jesus2099
Copy link
Owner

It seems that after MBS-3841 fix, links to recordings are now back to full URL with host (http://mb.org/recording/mbid).
URL without host (/recording/mbid) was (quite recent but) better, IMO.
I wonder if this drawback is intentional or just an oversight…

@jesus2099
Copy link
Owner

I will wait and see if it’s kept in live MBS…
Until then, as quick workaround, you can search replace href^='/ → href*='/ in both INLINE STUFF and MASS MERGE (two occurrences in each).
Tell me if you have more info. :)

@Freso
Copy link
Contributor Author

Freso commented Jan 28, 2015

http://tickets.musicbrainz.org/browse/MBS-3841
https://bitbucket.org/metabrainz/musicbrainz-server/pull-request/1375/mbs-3841-loading-releases-or-release/diff

@jesus2099
Copy link
Owner

I’m working on it, it’s eventually more drastic…
Maybe we will loose :

  • video icon
  • data track icon
  • track length in milliseconds
  • pending edit status
  • etc. ?

I hope only temporarily but I will have to make a request to the normal pages AND to the web services to get as much info as before on both local and remote releases.

jesus2099 added a commit that referenced this issue Feb 9, 2015
@jesus2099
MBS. work on MBS-3841 (TT release page is back) has started (issue #29).
e2f598a
jesus2099 added a commit that referenced this issue Feb 9, 2015
@jesus2099
MBS. release page back to old layout (issue #29, MBS-3841).
d336eaf
jesus2099 added a commit that referenced this issue Feb 9, 2015
@jesus2099
MBS. continuing trying to revert my features after release page back …
4e1ca34 
…to old layout (issue #29, MBS-3841).
@jesus2099
Copy link
Owner

For info, I am not currently working on making MASS MERGE RECORDINGS compatible with new layout…

I first repaired it without all the matching features (track times, track names, etc.), then I started re‑adding the features but then I have no time at the moment.

There is also PLAIN TEXT TRACKLISTS that would require to be changed but I have just repaired INLINE STUFF for the moment.

@jesus2099
Copy link
Owner

Here is a link to watch this issue for people without github account (RSS) and be informed of any news concerning this issue (if it’s empty it just means that there are no recent news).
It’s a Yahoo pipe where you can subscribe to an RSS feed (among other options).

@jesus2099
Copy link
Owner

splitting MBS-3841 related tickets from here :

@jesus2099 jesus2099 changed the title MASS MERGE: doesn't work with new many-recording-releases MASS MERGE RECORDINGS not working after MBS-3841 Feb 14, 2015
This was referenced Feb 14, 2015
Closed
Open
@jesus2099 jesus2099 mentioned this issue Mar 3, 2015
Closed
jesus2099 added a commit that referenced this issue Mar 6, 2015
@jesus2099
trying to merge MASS MERGE back to master (issue #29, MBS-3841).
ab5c0e6
jesus2099 added a commit that referenced this issue Mar 27, 2015
@jesus2099
MBS-3841. it works again but there are many regressions to fix (#29)
d730ad7
@jesus2099
Copy link
Owner

I have made it work without fixing the regressions.
I will close this ticket once I have listed all the regressions to fix (some require calling both release page and web service so it will be long to fix).

@jesus2099
Copy link
Owner

Here are some regressions I know :
The simple ones are #46 #47.
The maybe simple ones are #48 #49 #51 (but they would all be rewritten if/once an additional WS call is made for milliseconds in #48).
The one that will be difficult to overcome is #50 (remote release of more than 10 mediums).

jesus2099 added a commit that referenced this issue Jun 1, 2015
@jesus2099
FIX #79. MASS MERGE does work when local release has more than 10 med…
ebaea11 
…iums (post #29 / MBS-3841).

NEW. “Expand/collapse all mediums” buttons; useful when merging on local release with more than 10 (11+) mediums.
jesus2099 added a commit that referenced this issue Jun 3, 2015
@jesus2099
WORK‐AROUND #50: will not work when remote release has more than 10 m…
9bca653 
…ediums (post #29 / MBS-3841).

Now it is possible to have 11+ local release (added another #79 feature: all mediums expand before MASS MERGE appears).
Now it is possible to selectively load one of the mediums of an 11+ remote release (either paste “mbid/disc/x” URL or answer the prompt).
“Web Service mode” (#55) would eventually fix this completely.
@jesus2099 jesus2099 modified the milestone: 2015 Nov 20, 2015
@jesus2099 jesus2099 changed the title MASS MERGE RECORDINGS not working after MBS-3841 Doesn’t work with new many‐recording‐releases Jan 3, 2016
@jesus2099 jesus2099 modified the milestones: 2015, TEMP Feb 10, 2017
@jesus2099 jesus2099 modified the milestones: 2015, TEMP, 2015* Feb 10, 2017
jesus2099 added a commit that referenced this issue Aug 21, 2019
@jesus2099
MBS. work on MBS-3841 (TT release page is back) has started (issue #29).
e6da186
jesus2099 added a commit that referenced this issue Aug 21, 2019
@jesus2099
MBS. release page back to old layout (issue #29, MBS-3841).
68f1055
jesus2099 added a commit that referenced this issue Aug 21, 2019
@jesus2099
MBS. continuing trying to revert my features after release page back …
b813c46 
…to old layout (issue #29, MBS-3841).
jesus2099 added a commit that referenced this issue Aug 21, 2019
@jesus2099
trying to merge MASS MERGE back to master (issue #29, MBS-3841).
49738c4
jesus2099 added a commit that referenced this issue Aug 21, 2019
@jesus2099
MBS-3841. it works again but there are many regressions to fix (#29)
e2d722c
jesus2099 added a commit that referenced this issue Aug 21, 2019
@jesus2099
FIX #79. MASS MERGE does work when local release has more than 10 med…
14b8d1b 
…iums (post #29 / MBS-3841).

NEW. “Expand/collapse all mediums” buttons; useful when merging on local release with more than 10 (11+) mediums.
jesus2099 added a commit that referenced this issue Aug 21, 2019
@jesus2099
WORK‐AROUND #50: will not work when remote release has more than 10 m…
5f48b07 
…ediums (post #29 / MBS-3841).

Now it is possible to have 11+ local release (added another #79 feature: all mediums expand before MASS MERGE appears).
Now it is possible to selectively load one of the mediums of an 11+ remote release (either paste “mbid/disc/x” URL or answer the prompt).
“Web Service mode” (#55) would eventually fix this completely.
jesus2099 added a commit that referenced this issue Aug 21, 2019
@jesus2099
MBS. work on MBS-3841 (TT release page is back) has started (issue #29).
b33ee62
jesus2099 added a commit that referenced this issue Aug 21, 2019
@jesus2099
MBS. release page back to old layout (issue #29, MBS-3841).
15225f4
jesus2099 added a commit that referenced this issue Aug 21, 2019
@jesus2099
MBS. continuing trying to revert my features after release page back …
8575cc2 
…to old layout (issue #29, MBS-3841).
jesus2099 added a commit that referenced this issue Aug 21, 2019
@jesus2099
trying to merge MASS MERGE back to master (issue #29, MBS-3841).
bba92a7
jesus2099 added a commit that referenced this issue Aug 21, 2019
@jesus2099
MBS-3841. it works again but there are many regressions to fix (#29)
20636d5
jesus2099 added a commit that referenced this issue Aug 21, 2019
@jesus2099
FIX #79. MASS MERGE does work when local release has more than 10 med…
ca90da2 
…iums (post #29 / MBS-3841).

NEW. “Expand/collapse all mediums” buttons; useful when merging on local release with more than 10 (11+) mediums.
jesus2099 added a commit that referenced this issue Aug 21, 2019
@jesus2099
WORK‐AROUND #50: will not work when remote release has more than 10 m…
690ec09 
…ediums (post #29 / MBS-3841).

Now it is possible to have 11+ local release (added another #79 feature: all mediums expand before MASS MERGE appears).
Now it is possible to selectively load one of the mediums of an 11+ remote release (either paste “mbid/disc/x” URL or answer the prompt).
“Web Service mode” (#55) would eventually fix this completely.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
mb_MASS-MERGE-RECORDINGS server change
Projects
None yet
Milestone
2015
Development

No branches or pull requests
2 participants
@Freso @jesus2099