COOL_SEARCH_LINKS: Show pure entity edits (with and without relationships)

[jesus2099]

https://tickets.metabrainz.org/browse/MBS-11374

Filter out:

• recording edits
• work edits

[jesus2099]

I did not include relationships, though.
I don't know if it is possible.

[jesus2099]

It should work with does not match any and release is not MBID and type is not xxx and Relationship type is not yyy.
But it didn't work!

Example, this release has 2 Add disc ID edits.

The same release has 1 discogs edit.

But if I combine these (very long search time): I only get the disc ID edits, discogs edit is missing.

[jesus2099]

Ah OK it works but I have to include Add relationship in the edit types!

[jesus2099]

So maybe I will do this (and Remove relationship, and Add/Remove relationship attribute?) but it makes a very slow search to try to have both non-relationship edits and relationship edits.

[jesus2099]

I will make this:

Example with a release:

• Edit history (512 edits) (MBS)
  • Cover art edits (20 edits)
  • Entity edits (101 edits) (already done)
  • Entity relationship edits (3 edits, lacks the 5 pre-NGS relationship edits)
  • All Entity edits (109 edits) (PLEASE WAIT! VERY SLOW!)

[jesus2099]

Maybe I should try a more top-down logic order, where we can see which ones are included in which?

• Edit history (includes child entity edits) 512 edits
  • Entity edits (PLEASE WAIT! VERY VERY SLOW!) 109 edits
    • Non-relationship entity edits 101 edits
      • Cover art edits 20 edits
    • Entity relationship edits (PLEASE WAIT! VERY VERY SLOW!) 8 edits

Edit amounts are here for illustration, it would be too naughty with MBS to display them.

[jesus2099]

There are 3 Add relationship (post-NGS) edits (type 90):

• Edit #21853322 - Add relationship
• Edit #19931914 - Add relationship
• Edit #18807675 - Add relationship

But also 5 Add relationship (pre‐NGS) edits (type 233):

• Edit #12326996 - Add relationship (pre‐NGS)
• Edit #9908022 - Add relationship (pre‐NGS)
• Edit #8246501 - Add relationship (pre‐NGS)
• Edit #8155219 - Add relationship (pre‐NGS)
• Edit #8046063 - Add relationship (pre‐NGS)

Pre-NGS edit types are incompatible with post-NGS relationship types.
So if I want an edit search that gives me all relationship edits, I must use the same technique (edits that do not match any of the following conditions: is not, is not, is not) as the full search, which is very slow.

[jesus2099]

I could make a quick AJAX / XHR request to test if this entity has any pre-NGS relationship edits, to switch to the quick query, if not, and keep the slow query, if yes (if the test returns <div id="edits">).

Or maybe even more clever, is the NGS frontier the same as these old/new relationship frontier?

• First old relationship edit: Edit #2548537 - Add relationship (pre‐NGS)
• Last old relationship edit: Edit #14459454 - Add relationship (pre‐NGS)
  • First NGS edit: Edit #14459456 - Edit work (NGS)

Maybe I can use this 14459456 NGS magic number, or its date (2011-05-17), to avoid an AJAX / XHR check?

Maybe I could try to find the first NGS entity row ID for each type! No it's not valid.

• Area: Did not exist pre-NGS
• Artist: Oldest NGS artist 805,192 was never merged
• Event: Did not exist pre-NGS
• Instrument: Did not exist pre-NGS
• Label: Oldest NGS label 57,614 was never merged
• Place: Did not exist pre-NGS
• Release: Oldest NGS release 1,042,290 was never merged!
• Recording: Oldest NGS recording 12,425,925 was never merged ach but what about recordings added by release? Let's check the oldest NGS release above; its first recording, the oldest NGS release recording 12,425,844 was never merged, and it's indeed older than the first NGS standalone recording!
  • Track (historic): pre-NGS
  • Standalone recording: post-NGS
• Work: Did not exist pre-NGS but pre-NGS tracks with credits generated works on NGS migration, so it should also be tested. Let's try to find the oldest track credits. Most of them are now-recording or now-release credits. Apparently this is the oldest track (historic) now-work credit Edit #2549322 - Add relationship (pre‐NGS), but then, what? No I need to find the latest pre-NGS track (historic) now-work credit: Apparently this Edit #14459258 - Add relationship (pre‐NGS) and hurray phew this newest NGS migrated work 5,626,060 was never merged

Maybe those row ID could be reliable to judge if I put the slow search (pre-NGS entities) or the quick search (post-NGS entities).

But my method is not valid.
A newer row ID could still be pre-NGS if it was merged into a newer entity (greater row ID).

[jesus2099]

Kiwi Browser in landscape mode

Strange display on mobile, both in portrait and landscape modes.
The Pure entity edits should not appeared between refine and effective.

Maybe it's because the script running order is not the same in my mobile and on my PC.

[jesus2099]

It's indeed a problem in PENDING EDITS.

As soon as I run it before COOL_SEARCH_LINKS, it displays nicely.

[jesus2099]

Apparently I forgot Add medium edits for Releases.

[jesus2099]

Apparently I forgot to add links for Pure recording edits: https://musicbrainz.org/recording/2e87df3a-7b74-4ee3-8d04-73dfb094ed9f