Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid duplicated reviews #12

Merged
merged 10 commits into from
Sep 11, 2020
Merged

Avoid duplicated reviews #12

merged 10 commits into from
Sep 11, 2020

Conversation

jesusvasquez333
Copy link
Owner

@jesusvasquez333 jesusvasquez333 commented Sep 11, 2020

This PR avoid duplicates reviews: if the last review done by this modules was approved/requested changes, and the new state it is the same, the module won't redo the same action.

This resolves #6

@jesusvasquez333 jesusvasquez333 self-assigned this Sep 11, 2020
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This pull request does not contain a valid label. Please add one of the following labels: bug, enhancement

@jesusvasquez333 jesusvasquez333 added the enhancement New feature or request label Sep 11, 2020
github-actions[bot]
github-actions bot previously approved these changes Sep 11, 2020
github-actions[bot]
github-actions bot previously approved these changes Sep 11, 2020
@jesusvasquez333 jesusvasquez333 removed the enhancement New feature or request label Sep 11, 2020
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This pull request does not contain a valid label. Please add one of the following labels: bug, enhancement

@jesusvasquez333 jesusvasquez333 added the enhancement New feature or request label Sep 11, 2020
github-actions[bot]
github-actions bot previously approved these changes Sep 11, 2020
@jesusvasquez333 jesusvasquez333 removed the enhancement New feature or request label Sep 11, 2020
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This pull request does not contain a valid label. Please add one of the following labels: bug, enhancement

@jesusvasquez333 jesusvasquez333 added the enhancement New feature or request label Sep 11, 2020
@jesusvasquez333 jesusvasquez333 added bug Something isn't working and removed bug Something isn't working labels Sep 11, 2020
@jesusvasquez333 jesusvasquez333 merged commit 8608acc into master Sep 11, 2020
@jesusvasquez333 jesusvasquez333 deleted the avoid-duplicated-reviews branch September 11, 2020 03:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Feature: Do not comment when valid labels are present
1 participant