-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow PRs from forks #13
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pull_request_target
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This resolves #9.
The previous version didn't work when opening PRs from forks due to Github actions running with read-only permissions from forks.
Fortunately, Github recently added a new trigger event
pull_request_target
which behaves in an almost identical way to thepull_request
event, but the action runs in the base of the pull request and will therefore have write permission.However, as the action runs in the base of the pull request, the pull request number is not available in the environmental variables, which the code was using to extract the number automatically. Therefore, to use this new event, a new input argument was added in order to pass the pull request number which is available in the GitHub context
${{ github.event.pull_request.number }}
.So, for example, to allow PR from forks, in your workflow YAML file you should trigger with:
and use these steps (you just need to add the extra
pull-request-number
input):The changes are backward compatibles, so you can still use the
pull_request
tigger event, and in that case you don't need to specify the inputpull-request-number
as you did before. This however won't work with PRs from forks.