update deploy-gcp2

jesuyedavid · May 2, 2024 · 6c37f1b · 6c37f1b
1 parent 4ba2783
commit 6c37f1b
Show file tree

Hide file tree

Showing 3 changed files with 24 additions and 24 deletions.
diff --git a/.github/workflows/deploy_hold.yml b/.github/workflows/deploy_hold.yml
@@ -23,28 +23,28 @@ on:
         required: true
 
 jobs:
-  # deploy-aws:
-  #   runs-on: ubuntu-latest
-  #   environment: production # sets in github repo with reviewer requirement protection rule
-  #   steps:
-  #     - uses: actions/checkout@v4
-  #     - name: Download build-output-US artifact
-  #       uses: actions/download-artifact@v4
-  #       with:
-  #         name: build-output-US
-  #         path: dist/
-  #     - name: Configure AWS Credentials
-  #       uses: aws-actions/configure-aws-credentials@v4
-  #       with:
-  #         aws-access-key-id: ${{ secrets.AWS_ACCESS_KEY_ID }}
-  #         aws-secret-access-key: ${{ secrets.AWS_SECRET_ACCESS_KEY }}
-  #         aws-region: us-east-1
-  #     - name: Deploy to S3
-  #       run: |
-  #         aws s3 cp ./dist/ s3://assets.sitescdn.net/${{ inputs.bucket }}/${{ inputs.directory }} \
-  #         --acl public-read \
-  #         --recursive \
-  #         --cache-control ${{ inputs.cache-control }}
+  deploy-aws:
+    runs-on: ubuntu-latest
+    environment: production # sets in github repo with reviewer requirement protection rule
+    steps:
+      - uses: actions/checkout@v4
+      - name: Download build-output-US artifact
+        uses: actions/download-artifact@v4
+        with:
+          name: build-output-US
+          path: dist/
+      - name: Configure AWS Credentials
+        uses: aws-actions/configure-aws-credentials@v4
+        with:
+          aws-access-key-id: ${{ secrets.AWS_ACCESS_KEY_ID }}
+          aws-secret-access-key: ${{ secrets.AWS_SECRET_ACCESS_KEY }}
+          aws-region: us-east-1
+      - name: Deploy to S3
+        run: |
+          aws s3 cp ./dist/ s3://assets.sitescdn.net/${{ inputs.bucket }}/${{ inputs.directory }} \
+          --acl public-read \
+          --recursive \
+          --cache-control ${{ inputs.cache-control }}
 
   deploy-gcp:
     runs-on: ubuntu-latest

diff --git a/src/core/eventemitter/eventemitter.js b/src/core/eventemitter/eventemitter.js
@@ -62,7 +62,7 @@ export default class EventEmitter {
   /**
    * emit is the public interface for broadcasting messages/events
    * @param {string} evt the event name to publish from
-   * @param {Object} data the data to send along to the subscribers
+   * @param {Object} data the data to send along to the subscribers.
    */
   emit (evt, data) {
     const listeners = this._listeners[evt];

diff --git a/tests/ui/components/component.js b/tests/ui/components/component.js
@@ -13,7 +13,7 @@ import Storage from '../../../src/core/storage/storage';
 const DEFAULT_TEMPLATE = '<div>This is a default template {{name}}</div>';
 
 // Our render requires the native handlebars compiler,
-// and the set of precompiled templates for the components to use
+// and the set of precompiled templates for the components to use.
 const RENDERER = new HandlebarsRenderer({
   _hb: Handlebars,
   default: Handlebars.compile(DEFAULT_TEMPLATE)