Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cosmos: Fix unfold event numbering #322

Closed
bartelink opened this issue May 10, 2022 · 0 comments
Closed

Cosmos: Fix unfold event numbering #322

bartelink opened this issue May 10, 2022 · 0 comments
Labels
bug good-first-issue up-for-grabs https://up-for-grabs.net
Milestone
3.0

Comments

@bartelink
Copy link
Collaborator

There's a logic bug in the generation of Unfold records https://github.com/jet/equinox/blob/v3/src/Equinox.CosmosStore/CosmosStore.fs#L554-L555

I don't believe it's possible to actually trigger incorrect behavior as it stands, but it's definitely misleading and thus should be fixed, e that with or without a failing test.
@bartelink bartelink added this to the 3.0 milestone May 11, 2022
bartelink added a commit that referenced this issue May 11, 2022
@bartelink
Fix Unfold i numbering re #322
1cbd322
@bartelink bartelink mentioned this issue May 12, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug good-first-issue up-for-grabs https://up-for-grabs.net
Projects
None yet
Milestone
3.0
Development

No branches or pull requests
1 participant
@bartelink