Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Root cause or fix local shortcoming leading to FS0988 warnings #36

Closed
bartelink opened this issue Oct 19, 2018 · 4 comments
Closed

Root cause or fix local shortcoming leading to FS0988 warnings #36

bartelink opened this issue Oct 19, 2018 · 4 comments
Assignees

Comments

@bartelink
Copy link
Collaborator

For this repo, a central tenet has always been ./build should produce a clean build with no warnings

Atm it says:
warning FS0988: Main module of program is empty: nothing will happen when it is run

I'm OK with it remaining in the short term if there is a tooling fix in the works

@bartelink
Copy link
Collaborator Author

'Fixed' with 🙈 on cosmos branch in 86bdb41
@enricosada I don't like having to add an entrypoint (esp if I dont have to in C#) for a test assembly. I tried, but there's no clean way without adding an extra file that needs to be last in the order.
a) Am I doing it wrong
b) If I'm not, surely there should be a ticket about doing this properly somewhere (the trail runs dead here for me)

@enricosada
Copy link
Collaborator

enricosada commented Dec 14, 2018

should be already fixed in .net core sdk.
for test projects, the main will be automatically generated, if needed, like c#.
i'll check why isnt the case here

@bartelink
Copy link
Collaborator Author

ok - the offending project is only on the cosmos branch, but I thought it was happening in the others on master too (and that does not have that commit)

bartelink added a commit that referenced this issue Dec 19, 2018
@bartelink bartelink assigned enricosada and unassigned gusty Dec 19, 2018
@bartelink
Copy link
Collaborator Author

(As suggested by Enrico, pinning to 500+ removes this, so removed the hiding and all is well)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants