-
Notifications
You must be signed in to change notification settings - Fork 68
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Equinox.Tool: Add support for Cosmos Autoscaling #302
Conversation
Adds an `--autoscale`/`-A` switch to the `eqx` tool to enable support for the Autoscaling feature of Cosmos Containers and Databases. Specifying this flag causes the `--rus` parameter to be interpreted as "Maximum RU/s" and changes the default value to 4000 RU/s, the minimum value allowed by Cosmos.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for this PR!
Adding auto-scaling throughput seems pretty useful.
Tagging @bartelink
This looks great, thanks! Thanks for making the initial PR minimal and easy to review (without random whitespace changes). That said... I passive-aggressively pushed a commit just now with some formatting nits I wanted to do anyway addressed - some of these overlap with suggestions from @deviousasti @belcher-rok Can you Also, would you mind adding a line to the changelog.md with a link to the article you cited in the overview too pls? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good; minor comments added
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. Will merge after you force-push.
🙏 Thanks for the feedback @bartelink and @deviousasti! I need to learn more about partial active pattern -- they behave like magic🎇 Also, thanks for making these tools and frameworks available for all! |
Thanks for the contribution, and for doing the topping and tailing |
Adds an
--autoscale
/-A
switch to theeqx
tool to support autoscaling throughput of Cosmos containers and databases. Specifying this flag causes the--rus
parameter to be interpreted as "Maximum RU/s" and changes the default value to 4000 RU/s (the minimum MaxRUs value allowed by Cosmos).There are no changes to existing behavior. The Propulsion tool is also unaffected.
There are breaking changes in the
Equinox.CosmosStore.Core.Initialization.init
function, specifically themode
parameter'sProvisioning
type had itsrus
members changed toThroughput
type. TheinitAux
function remains unchanged.There is no plan to update the Propulsion tool since the minimum RU/s in both Manual and Autoscale mode is 400 which should be fine for the vast majority of 'aux' containers.