ResolveOption/FromMemento -> LoadOption #308
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bartelink
force-pushed
the
stj
branch
2 times, most recently
from
f60532e
to
ec4de8f
Compare
bartelink
force-pushed
the
v4-breaking
branch
from
27b93c8
to
4611959
Compare
bartelink
force-pushed
the
v4-breaking
branch
from
4611959
to
cb86e28
Compare
bartelink
force-pushed
the
v4-breaking
branch
from
cb86e28
to
54d15da
Compare
Open
bartelink
force-pushed
the
v4-breaking
branch
2 times, most recently
from
de03f25
to
c67c1f0
Compare
bartelink
force-pushed
the
v4-breaking
branch
2 times, most recently
from
a2d03cd
to
11afa8f
Compare
bartelink
force-pushed
the
v4-breaking
branch
from
7da9ae8
to
268107d
Compare
bartelink
force-pushed
the
stj
branch
2 times, most recently
from
df662b7
to
4705731
Compare
bartelink
force-pushed
the
v4-breaking
branch
from
268107d
to
7b47aef
Compare
bartelink
force-pushed
the
stj
branch
2 times, most recently
from
c86f703
to
0aeca93
Compare
bartelink
changed the title
bartelink
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Breaking changes via #232
ResolveOptionandXXXStoreCategory.FromMementoasLoadOptionWhile some of the changes in here were approximately in the outline plan, massive credit is due to @ahjohannessen who provided some excellent feedback, and equally important nudges that resulted in the code being much cleaner now.