-
Notifications
You must be signed in to change notification settings - Fork 68
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Equinox.StreamId #353
Merged
Add Equinox.StreamId #353
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nordfjord
reviewed
Nov 15, 2022
nordfjord
reviewed
Nov 15, 2022
nordfjord
reviewed
Nov 15, 2022
nordfjord
reviewed
Nov 16, 2022
nordfjord
reviewed
Nov 16, 2022
nordfjord
reviewed
Nov 16, 2022
Okay, my thinking cap has been on for a long time today so this is probably a horrible line of questioning. Given we already have a |
|
bartelink
commented
Nov 16, 2022
nordfjord
reviewed
Nov 16, 2022
nordfjord
reviewed
Nov 16, 2022
This is looking great! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Polishes the ids -> stream name -> Decider resolution process
struct
tuples from primary APIs (temp state from earlier performance work)The major credit must go to @nordfjord who provided the impetus for this effort, and had the final late night insight that leaves us with a well-named and Simple mechanism that resolves all the forces in the mapping process neatly