feat!(Stores): Category ctors take name + caching argument goes last #410
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bartelink
force-pushed
the
cats-have-names
branch
from
d830c57
to
b8e8d04
Compare
bartelink
commented
Jul 25, 2023
bartelink
commented
Jul 25, 2023
nordfjord
reviewed
Jul 25, 2023
| if act <> null then act.AddStream(categoryName, streamId, streamName).AddSyncAttempt(attempt) |> ignore | ||
| if act <> null then act.AddStream(name, streamId, streamName).AddLeader(requireLeader).AddStale(maxAge) |> ignore | ||
| return! inner.Load(log, name, streamId, streamName, maxAge, requireLeader, ct) } | ||
| member _.Sync(attempt, token, originState, events, ct) = task { |
There was a problem hiding this comment.
Ooh, I love the rebrand <3
There was a problem hiding this comment.
Yeah, I just wanted to Synchronize on terse naming. All I need is a Async.hronously and all my code will be very golfy
There was a problem hiding this comment.
module Async =
let heinously a = Async.RunSynchronously(a)
let hronously ct a = Async.Start(a, ct)I'm so here for this 🍿
Rename TrySync -> Sync
bartelink
force-pushed
the
cats-have-names
branch
from
0b6f417
to
6daad6d
Compare
nordfjord
reviewed
Jul 25, 2023
bartelink
changed the title
bartelink
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Following @nordfjord and @everzet's leadership in equinox-project/equinox-js#6
*StoreCategorytypes now have aNameas a second argument rather than having it littering theDecider.resolvepartial application chain.cachingargument moves to the end of the constructor argument list, to reflect that Caching, which was once a store-specific integration, is now a fairly separable decorator (one can imagine adjusting it so that it gets applied independent of theCategoryconstruction at some point)IME This has made factory wiring in apps much more terse, with less juggling of compiler errors, and also removes the ugly temporary
Equinox.Factoryname, so I trust that on balance this is a good change