Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Add a 'use' around linked cancellation tokens #221

Merged
merged 1 commit into from
Jun 25, 2023

Conversation

nordfjord
Copy link
Contributor

@nordfjord nordfjord commented Jun 25, 2023

I noticed that a lot of the objects that were surviving in my memory leak repro were CancellationTokenSources

image

Adding a use seems to solve for our memory leak

Before

Before

After

After

See this related stack overflow https://stackoverflow.com/questions/6960520/when-to-dispose-cancellationtokensource

@CLAassistant
Copy link

CLAassistant commented Jun 25, 2023

CLA assistant check
All committers have signed the CLA.

@bartelink bartelink merged commit 5ddddec into jet:master Jun 25, 2023
5 checks passed
@bartelink
Copy link
Collaborator

Thanks! And great to have the details and charts to accompany it

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants