Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Visualization as a list of refactoring changes in code diffs #97

Closed
anchouls opened this issue Jan 24, 2023 · 6 comments · Fixed by #101
Closed

Visualization as a list of refactoring changes in code diffs #97

anchouls opened this issue Jan 24, 2023 · 6 comments · Fixed by #101
Assignees
@anchouls

Comments

@anchouls
Copy link
Collaborator

Gutter helps to mark refactoring changes in code diffs. Changes must be presented as a list if there are several of them on one line.
@anchouls anchouls self-assigned this Jan 24, 2023
@anchouls
Copy link
Collaborator Author

Visualization can be represented like this:
image

At the moment I visualized like this:
image

Diffs shows when pressed. Perhaps a more detailed description can be shown on hover, if it is possible to define

@anchouls anchouls mentioned this issue Jan 24, 2023
Merged
anchouls added a commit that referenced this issue Jan 24, 2023
@anchouls
Added list of refactorings - #97
7623da9
@onewhl
Copy link
Collaborator

onewhl commented Jan 24, 2023

@anchouls, cool! I have a couple of suggestions✌️

  • Is it possible to make the size of the panel dependent on the text? I mean now the panel is quite wide in all cases, but it could be smaller/bigger depending on the count of characters in the refactoring description.

  • Also, the arrow on the right side of the panel makes me think that something will appear on the right side of it, but it opens an editor with diff. Maybe we can use another icon instead of arrow?

@anchouls
Copy link
Collaborator Author

I think this visualization is generally good:

Снимок экрана 2023-01-27 в 22 17 18

@onewhl
Copy link
Collaborator

onewhl commented Jan 28, 2023

@anchouls looks good, thank you!
Maybe we can use icons for method, class, variable like we do it here?

@anchouls
Copy link
Collaborator Author

anchouls commented Feb 3, 2023

Do you mean like in the first or second image?
photo_2023-02-03_02-01-47
photo_2023-02-03_02-02-04

@onewhl
Copy link
Collaborator

onewhl commented Feb 3, 2023

@anchouls , second image

@anchouls anchouls linked a pull request Feb 6, 2023 that will close this issue
Visualization as a list of refactoring changes in code diffs #101
Merged
anchouls added a commit that referenced this issue Feb 6, 2023
@anchouls
Added list of refactorings - #97
0f190b3
onewhl added a commit that referenced this issue Feb 6, 2023
@anchouls @onewhl
Visualization as a list of refactoring changes in code diffs (#101)
5b4d89e 
* Implement a gutter to mark refactoring changes in code diffs

* Store commit id for changed files

* Show gutter only close to refactoring changes

* Added show Diff

* Added button tool tip text

* Fix issue #95 and minor refactoring

* Added property - refactoring.detected.hint

* Added list of refactorings - #97

* Change visualization of list

* deleted files

---------

Co-authored-by: Zarina Kurbatova <zarina.kurbatova@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@anchouls anchouls

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Visualization as a list of refactoring changes in code diffs JetBrains-Research/RefactorInsight
2 participants
@onewhl @anchouls