Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Compatibility with IDEA is broken in master #37

Closed
steelart opened this issue Nov 12, 2019 · 1 comment
Closed

Compatibility with IDEA is broken in master #37

steelart opened this issue Nov 12, 2019 · 1 comment

Comments

@steelart
Copy link

LinkMap.Builder#normalizeDestination now has 2 parameters but InlineLinkGeneratingProvider#getRenderInfo is called it with 1 parameter.
@valich
Copy link
Collaborator

valich commented Nov 13, 2019

Processing destinations is different in different types of links in markdown (this is not stated very explicitly in spec, but it's there), so I think having a mandatory parameter is OK.

IntelliJ codebase has basically a copypaste of a part of this project; normally I hope this method won't be used very often to preserve (possibly, erroneous) compatibility variant.

I'll fix the code in IntelliJ.

@valich valich closed this as completed Nov 13, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@valich @steelart