Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

make AB::MB a configure_requires #2

Merged
merged 2 commits into from Mar 2, 2016
Merged

make AB::MB a configure_requires #2

merged 2 commits into from Mar 2, 2016

Conversation

plicease
Copy link
Contributor

@plicease plicease commented Mar 1, 2016

This will make sure that Alien::Base::ModuleBuild is correctly specified as a configure_requires. For the rationale for this change, please see Perl5-Alien/Alien-Base#157

@jeteve
Copy link
Owner

jeteve commented Mar 1, 2016

Hi, thanks a lot for the PR.

Sadly, the CI testing fails with:


syntax error at Build.PL line 77, near "meta_merge"
Global symbol "$builder" requires explicit package name at Build.PL line 84.

Can you fix it?

You can see Travis's tests for this branch here:

https://travis-ci.org/jeteve/Alien-ImageMagick/pull_requests

Thanks!

Jerome.

@plicease
Copy link
Contributor Author

plicease commented Mar 2, 2016

Fixed!

jeteve added a commit that referenced this pull request Mar 2, 2016
@jeteve jeteve merged commit 01d8ced into jeteve:master Mar 2, 2016
@jeteve
Copy link
Owner

jeteve commented Mar 2, 2016

Thanks a lot!

@plicease plicease deleted the configure_requires_fix branch March 2, 2016 12:52
ambs added a commit that referenced this pull request Apr 15, 2024
allow pinned image magick versions
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants