[process-compose] Improve port selection #1835
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
|
I'm not entirely sure what it does, but it looks like it worked in the GH Action. One question I had -- Do we want it to potentially grab any open port? Or would we rather have it randomly select a port within a given range? That would make it easier for developers to avoid potential port conflicts between their service and process-compose. |
Lagoja
approved these changes
Feb 23, 2024
|
@Lagoja I disallowed a few common ports. PTAL |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This helps fix the lapp and lepp stack test issues. It also provides a more reliable way to provide an unused port that does not have race condition issues or the limit of 10 ports.
How was it tested?
devbox services start