Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

The dual markers statistics are missing Δt and ∫ #40

Closed
mliberty1 opened this issue Jan 9, 2020 · 4 comments
Closed

The dual markers statistics are missing Δt and ∫ #40

mliberty1 opened this issue Jan 9, 2020 · 4 comments
Labels
bug Something isn't working

Comments

@mliberty1
Copy link
Member

mliberty1 commented Jan 9, 2020 •
edited
Loading

All platforms
0.7.0

The waveform view allows the user to add dual markers. The dual markers display the statistics over the selected window. Starting with 0.7.0, the statistics no longer include the delta time for the window or the integral:

image

The Joulescope UI used to display both of these statistics. This computation must have been lost when we restructured the markers to prevent crashes in 0.7.0. Future releases should include these statistics.
@mliberty1 mliberty1 added the bug Something isn't working label Jan 9, 2020
@mliberty1
Copy link
Member Author

Fixed in pyjoulescope commit 181a0b76c. Only ∫ added back since Δt is displayed above.

@mliberty1
Copy link
Member Author

Fixed for real. Made breaking API change in pyjoulescope statistics structure to make code more consistent. See

@mliberty1
Copy link
Member Author

Added configuration option to show/hide Δt for dual markers.
eeb59c9

@mliberty1
Copy link
Member Author

Fixed in 0.8.3

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@mliberty1