cert manager helm charts uses non-ascii hyphen

[derrickburns]

This causes a problem with tools that expect ascii. Can you please replace the unicode hyphen with a ascii hyphen?

$ curl -sL "https://github.com/jetstack/cert-manager/releases/download/v0.12.0/cert-manager.yaml"  | tr -cd '\11\12\15\40-\176' >/tmp/new-certmanager.yaml
$ curl -sL "https://github.com/jetstack/cert-manager/releases/download/v0.12.0/cert-manager.yaml"  >/tmp/orig-certmanager.yaml
$ cmp /tmp/orig-certmanager.yaml /tmp/new-certmanager.yaml
/tmp/orig-certmanager.yaml /tmp/new-certmanager.yaml differ: char 22698, line 560
$ diff /tmp/orig-certmanager.yaml /tmp/new-certmanager.yaml
560c560
<                         the DNS configuration for Akamai DNS—Zone Record Management
---
>                         the DNS configuration for Akamai DNSZone Record Management
1947c1947
<                               containing the DNS configuration for Akamai DNS—Zone
---
>                               containing the DNS configuration for Akamai DNSZone
3645c3645
<                               containing the DNS configuration for Akamai DNS—Zone
---
>                               containing the DNS configuration for Akamai DNSZone

[retest-bot]

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.
If this issue is safe to close now please do so with /close.
Send feedback to jetstack.
/lifecycle stale

[munnerz]

Huh, that's weird - if you could open a PR to adjust these line endings that'd be great 😅

/area deploy
/kind cleanup
/remove-lifecycle stale
/priority important-longterm
/good-first-issue

[jetstack-bot]

@munnerz:
This request has been marked as suitable for new contributors.

Please ensure the request meets the requirements listed here.

If this request no longer meets these requirements, the label can be removed
by commenting with the /remove-good-first-issue command.

In response to this:

Huh, that's weird - if you could open a PR to adjust these line endings that'd be great 😅

/area deploy
/kind cleanup
/remove-lifecycle stale
/priority important-longterm
/good-first-issue

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[meyskens]

Seems fixed in 0.16

Will close this.

/close

[jetstack-bot]

@meyskens: Closing this issue.

In response to this:

Seems fixed in 0.16

Will close this.

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.