Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add per-domain ACME metrics for requests #2727

Closed
christianhuening opened this issue Mar 23, 2020 · 7 comments
Closed

Add per-domain ACME metrics for requests #2727

christianhuening opened this issue Mar 23, 2020 · 7 comments
Labels
area/monitoring Indicates a PR or issue relates to monitoring kind/feature Categorizes issue or PR as related to a new feature. lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. priority/awaiting-more-evidence Lowest priority. Possibly useful, but not yet enough support to actually get it done.

Comments

@christianhuening
Copy link
Contributor

Is your feature request related to a problem? Please describe.
we sometimes run into the issue that developers exceed our weekly limits for certificate requests for certain domains (due to deletion and standup of dev environments).

Describe the solution you'd like
Though this can be mitigated by helm chart improvements etc. it would be super helpful to have a per-domain request metric exposed from the Cert-Manager

Describe alternatives you've considered
Simply make sure Ingress resources etc are not rolled out everytime in dev cluster. But we need visibility

Environment details (if applicable):

  • Kubernetes version (e.g. v1.10.2): v1.15.10
  • Cloud-provider/provisioner (e.g. GKE, kops AWS, etc): bare-metal, on-prem
  • cert-manager version (e.g. v0.4.0): v0.13.0
  • Install method (e.g. helm or static manifests): helm

/kind feature

@jetstack-bot jetstack-bot added the kind/feature Categorizes issue or PR as related to a new feature. label Mar 23, 2020
@munnerz
Copy link
Member

munnerz commented Apr 24, 2020

Hm, the issue here is that it will greatly increase the cardinality of our metrics if there are lots of domains in a cluster. I'm not 100% sure how to mitigate this given that's exactly what you want, but I don't think we can expose this metric by default at least.

/priority awaiting-more-evidence
/area monitoring

@jetstack-bot jetstack-bot added priority/awaiting-more-evidence Lowest priority. Possibly useful, but not yet enough support to actually get it done. area/monitoring Indicates a PR or issue relates to monitoring labels Apr 24, 2020
@christianhuening
Copy link
Contributor Author

hm well... having the option would great i think. Other than hiding it behind a flag i dont have a good idea I am afraid 🤔

@christianhuening
Copy link
Contributor Author

what if we'd only take the total number of requests and not per-domain?

@jetstack-bot
Copy link
Collaborator

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.
If this issue is safe to close now please do so with /close.
Send feedback to jetstack.
/lifecycle stale

@jetstack-bot jetstack-bot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Sep 15, 2021
@jetstack-bot
Copy link
Collaborator

Stale issues rot after 30d of inactivity.
Mark the issue as fresh with /remove-lifecycle rotten.
Rotten issues close after an additional 30d of inactivity.
If this issue is safe to close now please do so with /close.
Send feedback to jetstack.
/lifecycle rotten
/remove-lifecycle stale

@jetstack-bot jetstack-bot added lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. and removed lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. labels Oct 15, 2021
@jetstack-bot
Copy link
Collaborator

Rotten issues close after 30d of inactivity.
Reopen the issue with /reopen.
Mark the issue as fresh with /remove-lifecycle rotten.
Send feedback to jetstack.
/close

@jetstack-bot
Copy link
Collaborator

@jetstack-bot: Closing this issue.

In response to this:

Rotten issues close after 30d of inactivity.
Reopen the issue with /reopen.
Mark the issue as fresh with /remove-lifecycle rotten.
Send feedback to jetstack.
/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/monitoring Indicates a PR or issue relates to monitoring kind/feature Categorizes issue or PR as related to a new feature. lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. priority/awaiting-more-evidence Lowest priority. Possibly useful, but not yet enough support to actually get it done.
Projects
None yet
Development

No branches or pull requests

3 participants