Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[release-0.11] Add sideEffects: None to MutatingWebhookConfiguration #2213

Merged
merged 1 commit into from Oct 14, 2019
Merged

[release-0.11] Add sideEffects: None to MutatingWebhookConfiguration #2213

merged 1 commit into from Oct 14, 2019

Conversation

jetstack-bot
Copy link
Collaborator

This is an automated cherry-pick of #2206

/assign munnerz

[Kubernetes APIServer dry-run](https://kubernetes.io/docs/reference/using-api/api-concepts/#dry-run) is supported.

@ismailbaskin
Add sideEffects to MutatingWebhookConfiguration
549e040 
This is for supporting `kubectl --server-dry-run` feature.
It fixes cert-manager#2186.

Signed-off-by: ismail BASKIN <ismailbaskin5@gmail.com>
@jetstack-bot jetstack-bot added do-not-merge/cherry-pick-not-approved Indicates that a PR is not yet approved to merge into a release branch. release-note Denotes a PR that will be considered when it comes time to generate release notes. labels Oct 14, 2019
@jetstack-bot jetstack-bot added this to the v0.11 milestone Oct 14, 2019
@jetstack-bot jetstack-bot mentioned this pull request Oct 14, 2019
Merged
@jetstack-bot jetstack-bot added the dco-signoff: yes Indicates that all commits in the pull request have the valid DCO sign-off message. label Oct 14, 2019
@jetstack-bot jetstack-bot added area/deploy Indicates a PR modifies deployment configuration size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Oct 14, 2019
@munnerz munnerz added cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager and removed do-not-merge/cherry-pick-not-approved Indicates that a PR is not yet approved to merge into a release branch. labels Oct 14, 2019
@munnerz
Copy link
Member

munnerz commented Oct 14, 2019

/lgtm
/approve

@jetstack-bot jetstack-bot added the lgtm Indicates that a PR is ready to be merged. label Oct 14, 2019
@jetstack-bot
Copy link
Collaborator Author

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jetstack-bot, munnerz

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@jetstack-bot jetstack-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 14, 2019
@munnerz
Copy link
Member

munnerz commented Oct 14, 2019

/retest

@jetstack-bot jetstack-bot merged commit 17513e3 into cert-manager:release-0.11 Oct 14, 2019
This was referenced Oct 21, 2019
Closed
Closed
@jetstack-bot jetstack-bot mentioned this pull request Nov 27, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@munnerz munnerz Awaiting requested review from munnerz

Assignees

@munnerz munnerz

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/deploy Indicates a PR modifies deployment configuration cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager dco-signoff: yes Indicates that all commits in the pull request have the valid DCO sign-off message. lgtm Indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
v0.11
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@jetstack-bot @munnerz @ismailbaskin