Correct order api group owner reference when creating challenges

[CoaxVex]

fixes #2308

Signed-off-by: Nils Cant nils.cant@vargen.io

Fix setting ownerReference on Challenge resources created by Orders controller

[jetstack-bot]

Hi @CoaxVex. Thanks for your PR.

I'm waiting for a jetstack or cert-manager member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[jetstack-bot]

Thanks for your pull request. Before we can look at it, you'll need to add a 'DCO signoff' to your commits.

📝 Please follow instructions in the contributing guide to update your commits with the DCO

Full details of the Developer Certificate of Origin can be found at developercertificate.org.

The list of commits missing DCO signoff:

• dcd1f9f Add update permission on certificaterequests/finalizers to cert-manager-controller-certificates cluster role
• 0df53ce Revert "Add update permission on certificaterequests/finalizers to cert-manager-controller-certificates cluster role"

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

[munnerz]

/ok-to-test
/lgtm
/approve
/override dco

[jetstack-bot]

@munnerz: Overrode contexts on behalf of munnerz: dco

In response to this:

/ok-to-test
/lgtm
/approve
/override dco

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[jetstack-bot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: CoaxVex, munnerz

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [munnerz]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[munnerz]

/cherrypick release-0.11

[jetstack-bot]

@munnerz: once the present PR merges, I will cherry-pick it on top of release-0.11 in a new PR and assign it to you.

In response to this:

/cherrypick release-0.11

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[jetstack-bot]

@munnerz: new pull request created: #2333

In response to this:

/cherrypick release-0.11

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[abessifi]

Issue still exist on v0.12.0.

[CoaxVex]

Issue still exist on v0.12.0.

I don't believe this is the case. #2475 is a problem when using http01 challenges (I was using dns challenges).

[abessifi]

Yes, this is related to the http01 challenge method.
Do you think that the root cause isn't the same ?