Switch to using upstream golang.org/x/crypto #2422
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jetstack-bot
added
release-note
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: munnerz The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
jetstack-bot
added
approved
munnerz
force-pushed
the
x-crypto-acmev2
branch
from
3ea5366
to
b68c76a
Compare
munnerz
commented
Dec 3, 2019
pkg/acme/cache.go
Outdated
| @@ -90,7 +89,8 @@ func lookupClient(spec *cmacme.ACMEIssuer, pk *rsa.PrivateKey) *acmecl.Client { | |||
| HTTPClient: buildHTTPClient(spec.SkipTLSVerify), | |||
| Key: pk, | |||
| DirectoryURL: spec.Server, | |||
| UserAgent: util.CertManagerUserAgent, | |||
| // TODO: re-enable setting user agent | |||
There was a problem hiding this comment.
This needs fixing before merge
/hold
jetstack-bot
added
the
do-not-merge/hold
munnerz
force-pushed
the
x-crypto-acmev2
branch
from
0e9271e
to
d8b056e
Compare
Signed-off-by: James Munnelly <james@munnelly.eu>
Signed-off-by: James Munnelly <james@munnelly.eu>
Signed-off-by: James Munnelly <james@munnelly.eu>
munnerz
force-pushed
the
x-crypto-acmev2
branch
from
d8b056e
to
1f3b883
Compare
|
/hold cancel |
jetstack-bot
removed
the
do-not-merge/hold
|
/assign @JoshVanL |
|
/lgt |
|
/lgtm |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Switch to using upstream
golang.org/x/crypto/acmepackage.Since this now supports ACMEv2, we can (finally!) switch back to upstream! The structure of the package is basically the same, with a few slightly different variable/method names.
Release note:
/area acme
/kind cleanup