Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

issue 2443 - annotations for cert-manager deployments #2447

Merged
merged 1 commit into from
Dec 11, 2019

Conversation

nefischer
Copy link

What this PR does / why we need it: Adds support for cert-manager deployments annotations in the chart

Which issue this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close that issue when PR gets merged): fixes #2443

Special notes for your reviewer:

Release note:

Adds support for chart configurable parameters  `deploymentAnnotations`, `webhook.deploymentAnnotations` and `cainjector.deploymentAnnotations`

@jetstack-bot jetstack-bot added release-note Denotes a PR that will be considered when it comes time to generate release notes. dco-signoff: no Indicates that at least one commit in this pull request is missing the DCO sign-off message. labels Dec 10, 2019
@jetstack-bot jetstack-bot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Dec 10, 2019
@jetstack-bot
Copy link
Contributor

Hi @nefischer. Thanks for your PR.

I'm waiting for a jetstack or cert-manager member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@jetstack-bot jetstack-bot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. area/deploy Indicates a PR modifies deployment configuration labels Dec 10, 2019
@jetstack-bot jetstack-bot added dco-signoff: yes Indicates that all commits in the pull request have the valid DCO sign-off message. and removed dco-signoff: no Indicates that at least one commit in this pull request is missing the DCO sign-off message. labels Dec 10, 2019
@nefischer
Copy link
Author

/assign @munnerz

@munnerz
Copy link
Member

munnerz commented Dec 11, 2019

Makes sense to me! 😄

/lgtm
/approve
/ok-to-test

@jetstack-bot jetstack-bot added lgtm Indicates that a PR is ready to be merged. ok-to-test and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Dec 11, 2019
@jetstack-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: munnerz, nefischer

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@jetstack-bot jetstack-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 11, 2019
Signed-off-by: Nicolas Fischer <nicolas@emberspark.io>
@jetstack-bot jetstack-bot removed the lgtm Indicates that a PR is ready to be merged. label Dec 11, 2019
@nefischer
Copy link
Author

Resolved the conflict in values.yaml

@munnerz
Copy link
Member

munnerz commented Dec 11, 2019

/lgtm

@jetstack-bot jetstack-bot added the lgtm Indicates that a PR is ready to be merged. label Dec 11, 2019
@jetstack-bot jetstack-bot merged commit 02ee550 into cert-manager:master Dec 11, 2019
@jetstack-bot jetstack-bot added this to the v0.13 milestone Dec 11, 2019
@munnerz munnerz added this to Done in v0.13 Dec 17, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/deploy Indicates a PR modifies deployment configuration dco-signoff: yes Indicates that all commits in the pull request have the valid DCO sign-off message. lgtm Indicates that a PR is ready to be merged. ok-to-test release-note Denotes a PR that will be considered when it comes time to generate release notes. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
No open projects
v0.13
  
Done
Development

Successfully merging this pull request may close these issues.

Annotations for cert-manager deployments
3 participants