Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add configuration switch for use of apparmor in PSP #2489

Merged
merged 1 commit into from
Jan 9, 2020
Merged

Add configuration switch for use of apparmor in PSP #2489

merged 1 commit into from
Jan 9, 2020

Conversation

czunker
Copy link
Contributor

@czunker czunker commented Dec 27, 2019

Fixes #2293

What this PR does / why we need it:

It fixes #2293
The helm chart now allows to configure whether Apparmor should be used or not.

It is done in the same way, as it is implemented for grafana:
https://github.com/helm/charts/blob/master/stable/grafana/templates/podsecuritypolicy.yaml#L15

Which issue this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close that issue when PR gets merged): fixes #2293

Special notes for your reviewer:

Release note:

It is now possible to disable Apparmor when PSPs are used.

@jetstack-bot jetstack-bot added release-note Denotes a PR that will be considered when it comes time to generate release notes. dco-signoff: no Indicates that at least one commit in this pull request is missing the DCO sign-off message. labels Dec 27, 2019
@jetstack-bot
Copy link
Contributor

Hi @czunker. Thanks for your PR.

I'm waiting for a jetstack or cert-manager member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@jetstack-bot jetstack-bot added needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. area/deploy Indicates a PR modifies deployment configuration labels Dec 27, 2019
@jetstack-bot jetstack-bot added dco-signoff: yes Indicates that all commits in the pull request have the valid DCO sign-off message. and removed dco-signoff: no Indicates that at least one commit in this pull request is missing the DCO sign-off message. labels Dec 27, 2019
munnerz
munnerz reviewed Jan 7, 2020
View reviewed changes
deploy/charts/cert-manager/README.md Outdated
@@ -77,6 +77,7 @@ The following table lists the configurable parameters of the cert-manager chart
| `global.rbac.create` | If `true`, create and use RBAC resources (includes sub-charts) | `true` |
| `global.priorityClassName`| Priority class name for cert-manager and webhook pods | `""` |
| `global.podSecurityPolicy.enabled` | If `true`, create and use PodSecurityPolicy (includes sub-charts) | `false` |
| `global.podSecurityPolicy.useApparmor` | If `true`, use Apparmor seccomp profile in PSP | `true` |
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you make this useAppArmor (capatalised A on Armor)? This is in-line with the grafana chart too 😄

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure.

@munnerz
Copy link
Member

munnerz commented Jan 7, 2020

This looks good to me aside from the one comment 😄 thanks!

Add configuration switch for use of apparmor in PSP
7f5ac29 
Fixes cert-manager#2293

Signed-off-by: Christian Zunker <christian.zunker@codecentric.cloud>
@munnerz
Copy link
Member

munnerz commented Jan 9, 2020

/lgtm
/approve
/ok-to-test

@jetstack-bot jetstack-bot added ok-to-test lgtm Indicates that a PR is ready to be merged. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Jan 9, 2020
@jetstack-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: czunker, munnerz

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@jetstack-bot jetstack-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 9, 2020
@jetstack-bot jetstack-bot merged commit b739081 into cert-manager:master Jan 9, 2020
@jetstack-bot jetstack-bot added this to the v0.13 milestone Jan 9, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@munnerz munnerz munnerz left review comments

Assignees

@munnerz munnerz

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/deploy Indicates a PR modifies deployment configuration dco-signoff: yes Indicates that all commits in the pull request have the valid DCO sign-off message. lgtm Indicates that a PR is ready to be merged. ok-to-test release-note Denotes a PR that will be considered when it comes time to generate release notes. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
v0.13
Development

Successfully merging this pull request may close these issues.

Helm chart fails when PSP is true but nodes don't support AppArmor
3 participants
@czunker @jetstack-bot @munnerz