Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes for the validating and mutating webhook configuration #2831

Merged
merged 1 commit into from Apr 23, 2020
Merged

Fixes for the validating and mutating webhook configuration #2831

merged 1 commit into from Apr 23, 2020

Conversation

wallrj
Copy link
Member

@wallrj wallrj commented Apr 23, 2020 •
edited

  • Use the correct URL path for validation
  • Also validate v1alpha3 API objects

Fixes: #2754
Fixes: #2822

Signed-off-by: Richard Wall richard.wall@jetstack.io

Fix validatingwebhookconfiguration to use correct URL path and to suport v1alpha3 API objects.

@jetstack-bot jetstack-bot added release-note Denotes a PR that will be considered when it comes time to generate release notes. dco-signoff: yes Indicates that all commits in the pull request have the valid DCO sign-off message. needs-kind Indicates a PR lacks a `kind/foo` label and requires one. area/deploy Indicates a PR modifies deployment configuration labels Apr 23, 2020
@jetstack-bot jetstack-bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Apr 23, 2020
@wallrj
Fixes for the validating and mutating webhook configuration
f37e0cd 
* Use the correct URL path for validation
* Validate v1alpha3 API objects
* Mutate v1alpha3 API objects

Signed-off-by: Richard Wall <richard.wall@jetstack.io>
@wallrj wallrj changed the title Fixes for the validating webhook configuration Fixes for the validating and mutating webhook configuration Apr 23, 2020
@munnerz
Copy link
Member

munnerz commented Apr 23, 2020

/kind bug
/lgtm
/approve
/cherrypick release-0.14

@jetstack-bot
Copy link
Collaborator

@munnerz: once the present PR merges, I will cherry-pick it on top of release-0.14 in a new PR and assign it to you.

In response to this:

/kind bug
/lgtm
/approve
/cherrypick release-0.14

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@jetstack-bot jetstack-bot added kind/bug Categorizes issue or PR as related to a bug. lgtm Indicates that a PR is ready to be merged. and removed needs-kind Indicates a PR lacks a `kind/foo` label and requires one. labels Apr 23, 2020
@jetstack-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: munnerz, wallrj

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@jetstack-bot jetstack-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 23, 2020
@jetstack-bot jetstack-bot merged commit f0231cc into cert-manager:master Apr 23, 2020
@jetstack-bot jetstack-bot added this to the v0.15 milestone Apr 23, 2020
@jetstack-bot jetstack-bot mentioned this pull request Apr 23, 2020
Merged
@jetstack-bot
Copy link
Collaborator

@munnerz: new pull request created: #2832

In response to this:

/kind bug
/lgtm
/approve
/cherrypick release-0.14

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@wallrj wallrj deleted the 2754-webhook-config branch April 24, 2020 07:21
This was referenced Apr 28, 2020
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@munnerz munnerz Awaiting requested review from munnerz

Assignees

@munnerz munnerz

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/deploy Indicates a PR modifies deployment configuration dco-signoff: yes Indicates that all commits in the pull request have the valid DCO sign-off message. kind/bug Categorizes issue or PR as related to a bug. lgtm Indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
v0.15
3 participants
@wallrj @munnerz @jetstack-bot