Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[release-0.14] Set Issuer kind specific to Issuer if /issuer is specified #2838

Merged
merged 1 commit into from
Apr 27, 2020
Merged

[release-0.14] Set Issuer kind specific to Issuer if /issuer is specified #2838

merged 1 commit into from
Apr 27, 2020

Conversation

jetstack-bot
Copy link
Contributor

This is an automated cherry-pick of #2837

/assign munnerz

Fix case where cert-manager.io/issuer doesn't set `Issuer` kind

@meyskens
Set Issuer kind specific to Issuer if cert-manager.io/issuer is speci…
beee3bc 
…fied.

Signed-off-by: Maartje Eyskens <maartje@eyskens.me>
@jetstack-bot jetstack-bot mentioned this pull request Apr 24, 2020
Merged
@jetstack-bot jetstack-bot added this to the v0.14 milestone Apr 24, 2020
@jetstack-bot jetstack-bot added release-note Denotes a PR that will be considered when it comes time to generate release notes. do-not-merge/cherry-pick-not-approved Indicates that a PR is not yet approved to merge into a release branch. dco-signoff: yes Indicates that all commits in the pull request have the valid DCO sign-off message. labels Apr 24, 2020
@jetstack-bot jetstack-bot added needs-kind Indicates a PR lacks a `kind/foo` label and requires one. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Apr 24, 2020
@munnerz munnerz added cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager and removed do-not-merge/cherry-pick-not-approved Indicates that a PR is not yet approved to merge into a release branch. labels Apr 24, 2020
@munnerz
Copy link
Member

munnerz commented Apr 24, 2020

/lgtm
/approve

@jetstack-bot jetstack-bot added the lgtm Indicates that a PR is ready to be merged. label Apr 24, 2020
@jetstack-bot
Copy link
Contributor Author

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jetstack-bot, munnerz

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@jetstack-bot jetstack-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 24, 2020
@munnerz
Copy link
Member

munnerz commented Apr 27, 2020

/kind cleanup

@jetstack-bot jetstack-bot added kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. and removed needs-kind Indicates a PR lacks a `kind/foo` label and requires one. labels Apr 27, 2020
@jetstack-bot jetstack-bot merged commit 3df3671 into cert-manager:release-0.14 Apr 27, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@meyskens meyskens Awaiting requested review from meyskens

Assignees

@munnerz munnerz

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager dco-signoff: yes Indicates that all commits in the pull request have the valid DCO sign-off message. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lgtm Indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
v0.14
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@jetstack-bot @munnerz @meyskens