Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[release-0.14] cloudfare: update per_page max to 100 #2859

Merged
merged 1 commit into from
Apr 28, 2020
Merged

[release-0.14] cloudfare: update per_page max to 100 #2859

merged 1 commit into from
Apr 28, 2020

Conversation

jetstack-bot
Copy link
Contributor

This is an automated cherry-pick of #2856

/assign meyskens

Limit `per_page` to 100 in Cloudfare API calls

cloudfare: update per_page max to 100
d004131 
cloudfare just changed the maximum of per_page in their API to 100.

  Warning  PresentError  2m41s (x11 over 75m)  cert-manager
  Error presenting challenge: Cloudflare API Error
  Error: 9205: Per_Page must be a number between 5 and 100

This change fixes that.

Signed-off-by: Mehdi Abaakouk <sileht@sileht.net>
@jetstack-bot jetstack-bot added the release-note Denotes a PR that will be considered when it comes time to generate release notes. label Apr 28, 2020
@jetstack-bot jetstack-bot added this to the v0.14 milestone Apr 28, 2020
@jetstack-bot jetstack-bot added the do-not-merge/cherry-pick-not-approved Indicates that a PR is not yet approved to merge into a release branch. label Apr 28, 2020
@jetstack-bot jetstack-bot mentioned this pull request Apr 28, 2020
Merged
@jetstack-bot jetstack-bot added the dco-signoff: yes Indicates that all commits in the pull request have the valid DCO sign-off message. label Apr 28, 2020
@jetstack-bot jetstack-bot added area/acme Indicates a PR directly modifies the ACME Issuer code area/acme/dns01 Indicates a PR modifies ACME DNS01 provider code needs-kind Indicates a PR lacks a `kind/foo` label and requires one. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Apr 28, 2020
@meyskens meyskens added cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager and removed do-not-merge/cherry-pick-not-approved Indicates that a PR is not yet approved to merge into a release branch. labels Apr 28, 2020
@meyskens
Copy link
Contributor

/kind bug
/approve
/lgtm

@jetstack-bot jetstack-bot added lgtm Indicates that a PR is ready to be merged. kind/bug Categorizes issue or PR as related to a bug. and removed needs-kind Indicates a PR lacks a `kind/foo` label and requires one. labels Apr 28, 2020
@jetstack-bot
Copy link
Contributor Author

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jetstack-bot, meyskens

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@jetstack-bot jetstack-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 28, 2020
@jetstack-bot jetstack-bot merged commit 2241b3b into cert-manager:release-0.14 Apr 28, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@munnerz munnerz Awaiting requested review from munnerz

Assignees

@meyskens meyskens

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/acme/dns01 Indicates a PR modifies ACME DNS01 provider code area/acme Indicates a PR directly modifies the ACME Issuer code cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager dco-signoff: yes Indicates that all commits in the pull request have the valid DCO sign-off message. kind/bug Categorizes issue or PR as related to a bug. lgtm Indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
v0.14
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@jetstack-bot @meyskens