Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove custom retry logic from route53 package #2898

Merged
merged 2 commits into from Jun 11, 2020
Merged

Remove custom retry logic from route53 package #2898

merged 2 commits into from Jun 11, 2020

Conversation

diversario
Copy link
Contributor

@diversario diversario commented May 6, 2020 •
edited by meyskens

Signed-off-by: Ilya Shaisultanov ilya.shaisultanov@gmail.com

What this PR does / why we need it:
ACME challenges controller already handles retry logic. This
avoid an issue where cert-manager can spam Route53 under certain
conditions, leading to throttling.

Which issue this PR fixes : fixes #2159.

Special notes for your reviewer:

I used make verify to test this, unsure if that's the best way.

Release note:

Remove custom retry logic from Route53 DNS01

@diversario
Remove custom retry logic from route53 package
bebd82c 
ACME challenges controller already handles retry logic. This
avoid an issue where cert-manager can spam Route53 under certain
conditions, leading to throttling.

Fixes cert-manager#2159.

Signed-off-by: Ilya Shaisultanov <ilya.shaisultanov@gmail.com>
@jetstack-bot jetstack-bot added dco-signoff: yes Indicates that all commits in the pull request have the valid DCO sign-off message. do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. needs-kind Indicates a PR lacks a `kind/foo` label and requires one. area/acme Indicates a PR directly modifies the ACME Issuer code labels May 6, 2020
@jetstack-bot
Copy link
Collaborator

Hi @diversario. Thanks for your PR.

I'm waiting for a jetstack or cert-manager member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@jetstack-bot jetstack-bot requested a review from munnerz May 6, 2020 22:14
@jetstack-bot jetstack-bot added needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. area/acme/dns01 Indicates a PR modifies ACME DNS01 provider code size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels May 6, 2020
@jetstack-bot jetstack-bot added dco-signoff: no Indicates that at least one commit in this pull request is missing the DCO sign-off message. and removed dco-signoff: yes Indicates that all commits in the pull request have the valid DCO sign-off message. labels May 7, 2020
@diversario
Remove unused retryer
280aa26 
Signed-off-by: Ilya Shaisultanov <ilya.shaisultanov@gmail.com>
@jetstack-bot jetstack-bot added dco-signoff: yes Indicates that all commits in the pull request have the valid DCO sign-off message. and removed dco-signoff: no Indicates that at least one commit in this pull request is missing the DCO sign-off message. labels May 7, 2020
@diversario diversario requested a review from munnerz May 11, 2020 08:12
@jetstack-bot jetstack-bot added release-note Denotes a PR that will be considered when it comes time to generate release notes. and removed do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. labels Jun 11, 2020
@meyskens
Copy link
Contributor

/ok-to-test

@jetstack-bot jetstack-bot added ok-to-test and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Jun 11, 2020
@meyskens
Copy link
Contributor

Sorry for the delay! Thanks for the PR!

/lgtm
/approve

@jetstack-bot jetstack-bot added the lgtm Indicates that a PR is ready to be merged. label Jun 11, 2020
@meyskens
Copy link
Contributor

/kind cleanup

@jetstack-bot jetstack-bot added kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. and removed needs-kind Indicates a PR lacks a `kind/foo` label and requires one. labels Jun 11, 2020
@jetstack-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: diversario, meyskens

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@jetstack-bot jetstack-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 11, 2020
@jetstack-bot jetstack-bot merged commit 89c8fc3 into cert-manager:master Jun 11, 2020
@jetstack-bot jetstack-bot added this to the v0.16 milestone Jun 11, 2020
@diversario diversario deleted the 2159-remove-custom-retryer branch July 7, 2020 16:23
@AntonyBishop AntonyBishop mentioned this pull request Sep 28, 2020
Closed
@munnerz munnerz mentioned this pull request Dec 1, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@munnerz munnerz Awaiting requested review from munnerz

Assignees

@meyskens meyskens

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/acme/dns01 Indicates a PR modifies ACME DNS01 provider code area/acme Indicates a PR directly modifies the ACME Issuer code dco-signoff: yes Indicates that all commits in the pull request have the valid DCO sign-off message. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lgtm Indicates that a PR is ready to be merged. ok-to-test release-note Denotes a PR that will be considered when it comes time to generate release notes. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
v0.16
Development

Successfully merging this pull request may close these issues.

cert-manager spams route53 when it is not allowed to change the zone
4 participants
@diversario @jetstack-bot @meyskens @munnerz