Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[release-0.16] Adds Issuer Group to Secret annotation #3153

Merged
merged 3 commits into from Aug 7, 2020
Merged

[release-0.16] Adds Issuer Group to Secret annotation #3153

merged 3 commits into from Aug 7, 2020

Conversation

jetstack-bot
Copy link
Collaborator

This is an automated cherry-pick of #3151

/assign JoshVanL

Ensures Secrets created from the Certificates controller contains the annotation containing the Issuer Group Name.

@JoshVanL
Adds Issuer Group to Secret annotation
59d7fcb 
Signed-off-by: JoshVanL <vleeuwenjoshua@gmail.com>
@JoshVanL
Adds integration test for issuer controller secret annotations, and f…
f11c1c7 
…ixes GenerateTempalate func

Signed-off-by: JoshVanL <vleeuwenjoshua@gmail.com>
@JoshVanL
Refactor issuer controller integration test to ensure Secret is updat…
2c67674 
…ed in single update

Signed-off-by: JoshVanL <vleeuwenjoshua@gmail.com>
@jetstack-bot jetstack-bot added this to the v0.16 milestone Aug 6, 2020
@jetstack-bot jetstack-bot mentioned this pull request Aug 6, 2020
Merged
@jetstack-bot jetstack-bot added release-note Denotes a PR that will be considered when it comes time to generate release notes. do-not-merge/cherry-pick-not-approved Indicates that a PR is not yet approved to merge into a release branch. dco-signoff: yes Indicates that all commits in the pull request have the valid DCO sign-off message. labels Aug 6, 2020
@jetstack-bot jetstack-bot added area/testing Issues relating to testing needs-kind Indicates a PR lacks a `kind/foo` label and requires one. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Aug 6, 2020
@JoshVanL
Copy link
Collaborator

JoshVanL commented Aug 6, 2020

/unassign
/assign @wallrj

@jetstack-bot jetstack-bot assigned wallrj and unassigned JoshVanL Aug 6, 2020
wallrj
wallrj approved these changes Aug 6, 2020
View reviewed changes
Copy link
Member

@wallrj wallrj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Josh.

/lgtm
/approve

@jetstack-bot jetstack-bot added the lgtm Indicates that a PR is ready to be merged. label Aug 6, 2020
@meyskens
Copy link
Contributor

meyskens commented Aug 7, 2020

/approve

@jetstack-bot
Copy link
Collaborator Author

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jetstack-bot, meyskens, wallrj

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@jetstack-bot jetstack-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 7, 2020
@meyskens meyskens added cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager and removed do-not-merge/cherry-pick-not-approved Indicates that a PR is not yet approved to merge into a release branch. labels Aug 7, 2020
@meyskens
Copy link
Contributor

meyskens commented Aug 7, 2020

/kind bug

@jetstack-bot jetstack-bot added kind/bug Categorizes issue or PR as related to a bug. and removed needs-kind Indicates a PR lacks a `kind/foo` label and requires one. labels Aug 7, 2020
@jetstack-bot jetstack-bot merged commit a7f8065 into cert-manager:release-0.16 Aug 7, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wallrj wallrj wallrj approved these changes

@munnerz munnerz Awaiting requested review from munnerz

Assignees

@wallrj wallrj

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/testing Issues relating to testing cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager dco-signoff: yes Indicates that all commits in the pull request have the valid DCO sign-off message. kind/bug Categorizes issue or PR as related to a bug. lgtm Indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
v0.16
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@jetstack-bot @JoshVanL @meyskens @wallrj