Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[release-1.0] Fix double "signing" KU validation #3306

Merged
merged 4 commits into from Sep 22, 2020
Merged

[release-1.0] Fix double "signing" KU validation #3306

merged 4 commits into from Sep 22, 2020

Conversation

jetstack-bot
Copy link
Collaborator

This is an automated cherry-pick of #3279

/assign wallrj

Fixes incorrect CSR validation when both "signing" and "digital signature" are set

@meyskens
Fixes validation when teh 2 signing keys are set
5d1b797 
Signed-off-by: Maartje Eyskens <maartje@eyskens.me>
@meyskens
Update bazel
d283077 
Signed-off-by: Maartje Eyskens <maartje@eyskens.me>
@meyskens
Add test to test not erroring on reordered values
26513a5 
Signed-off-by: Maartje Eyskens <maartje@eyskens.me>
@meyskens
Fix edge case with isCA
772d3cc 
Signed-off-by: Maartje Eyskens <maartje@eyskens.me>
@jetstack-bot jetstack-bot mentioned this pull request Sep 22, 2020
Merged
@jetstack-bot jetstack-bot added this to the v1.0 milestone Sep 22, 2020
@jetstack-bot jetstack-bot added do-not-merge/cherry-pick-not-approved Indicates that a PR is not yet approved to merge into a release branch. release-note Denotes a PR that will be considered when it comes time to generate release notes. dco-signoff: yes Indicates that all commits in the pull request have the valid DCO sign-off message. labels Sep 22, 2020
@jetstack-bot jetstack-bot added needs-kind Indicates a PR lacks a `kind/foo` label and requires one. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Sep 22, 2020
wallrj
wallrj approved these changes Sep 22, 2020
View reviewed changes
Copy link
Member

@wallrj wallrj left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve
/lgtm
/kind bug

@jetstack-bot
Copy link
Collaborator Author

@wallrj: The label(s) kind/bugfix cannot be applied, because the repository doesn't have them

In response to this:

/approve
/lgtm
/kind bugfix

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@jetstack-bot jetstack-bot added the lgtm Indicates that a PR is ready to be merged. label Sep 22, 2020
@wallrj
Copy link
Member

wallrj commented Sep 22, 2020

/kind bug

@jetstack-bot jetstack-bot added kind/bug Categorizes issue or PR as related to a bug. and removed needs-kind Indicates a PR lacks a `kind/foo` label and requires one. labels Sep 22, 2020
@wallrj wallrj added the cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager label Sep 22, 2020
@jetstack-bot jetstack-bot removed the do-not-merge/cherry-pick-not-approved Indicates that a PR is not yet approved to merge into a release branch. label Sep 22, 2020
@jakexks
Copy link
Member

jakexks commented Sep 22, 2020

/approve

2 similar comments
@wallrj
Copy link
Member

wallrj commented Sep 22, 2020

/approve

@meyskens
Copy link
Contributor

/approve

@jetstack-bot
Copy link
Collaborator Author

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jakexks, jetstack-bot, meyskens, wallrj

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@jetstack-bot jetstack-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 22, 2020
@jetstack-bot jetstack-bot merged commit 219b793 into cert-manager:release-1.0 Sep 22, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wallrj wallrj wallrj approved these changes

@munnerz munnerz Awaiting requested review from munnerz

Assignees

@wallrj wallrj

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager dco-signoff: yes Indicates that all commits in the pull request have the valid DCO sign-off message. kind/bug Categorizes issue or PR as related to a bug. lgtm Indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
v1.0
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@jetstack-bot @wallrj @jakexks @meyskens