Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[release-1.0] Fix auth zone hostedZoneID lookups. #3375

Merged
merged 1 commit into from Oct 13, 2020
Merged

[release-1.0] Fix auth zone hostedZoneID lookups. #3375

merged 1 commit into from Oct 13, 2020

Conversation

jetstack-bot
Copy link
Collaborator

This is an automated cherry-pick of #3354

/assign meyskens

Fix bug in AWS route53 zone lookup that caused too many IAM requests

Fix auth zone hosted domain lookups.
0189cba 
Changes:
    1. When there are multiple route53 hosted top zone and delegated
    zones within the same account, cert-manager incorrectly uses
    the top level domain as auth zone for which it doesn't have perms.
    This DOSes AWS's IAM API.
    2. This change adds the best match in determining auth zone while
    looking up hosted zone IDs.
    3. Defines a GetBestMatch util function to perform longest domain
    matches.
    4. Adds test cases
    5. Fixes cert-manager#3353

Signed-off-by: Supriya Premkumar <supriyapremkumar1@gmail.com>
@jetstack-bot jetstack-bot mentioned this pull request Oct 13, 2020
Merged
@jetstack-bot jetstack-bot added release-note Denotes a PR that will be considered when it comes time to generate release notes. do-not-merge/cherry-pick-not-approved Indicates that a PR is not yet approved to merge into a release branch. dco-signoff: yes Indicates that all commits in the pull request have the valid DCO sign-off message. needs-kind Indicates a PR lacks a `kind/foo` label and requires one. labels Oct 13, 2020
@jetstack-bot jetstack-bot added area/acme Indicates a PR directly modifies the ACME Issuer code size/L Denotes a PR that changes 100-499 lines, ignoring generated files. area/acme/dns01 Indicates a PR modifies ACME DNS01 provider code labels Oct 13, 2020
@meyskens
Copy link
Contributor

/lgtm
/approve

@jetstack-bot jetstack-bot added the lgtm Indicates that a PR is ready to be merged. label Oct 13, 2020
@jetstack-bot
Copy link
Collaborator Author

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jetstack-bot, meyskens

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@jetstack-bot jetstack-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 13, 2020
@meyskens meyskens added the cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager label Oct 13, 2020
@jetstack-bot jetstack-bot removed the do-not-merge/cherry-pick-not-approved Indicates that a PR is not yet approved to merge into a release branch. label Oct 13, 2020
@meyskens
Copy link
Contributor

/kind bug

@jetstack-bot jetstack-bot added kind/bug Categorizes issue or PR as related to a bug. and removed needs-kind Indicates a PR lacks a `kind/foo` label and requires one. labels Oct 13, 2020
@jetstack-bot jetstack-bot merged commit 530216c into cert-manager:release-1.0 Oct 13, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@meyskens meyskens Awaiting requested review from meyskens

@munnerz munnerz Awaiting requested review from munnerz

Assignees

@meyskens meyskens

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/acme/dns01 Indicates a PR modifies ACME DNS01 provider code area/acme Indicates a PR directly modifies the ACME Issuer code cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager dco-signoff: yes Indicates that all commits in the pull request have the valid DCO sign-off message. kind/bug Categorizes issue or PR as related to a bug. lgtm Indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@jetstack-bot @meyskens