Helm cleanup

[inteon]

What this PR does / why we need it:

1. Currently a very complex bazel workflow is used to generate static yaml files from the helm chart.
   This PR drastically simplifies that workflow, by moving most of the logic to the helm file and by removing unnecessary operations.

2. The helm value components is added, this value selects what resources should be included in the rendered helm chart.
   Now we can do a helm install where the CRDs are in a separate helm deployment (this logic is also used for static yaml generation):

helm template \
  cert-manager jetstack/cert-manager \
  --set components={crd} \
  --version v1.4.0 | kubectl apply -f -

helm install \
  cert-manager jetstack/cert-manager \
  --namespace cert-manager \
  --create-namespace \
  --version v1.4.0

4. The installCRDs helm value can be replaced by components. I added a deprecation warning notifying the chart user that this option might get removed in later releases.

Release note:

/kind cleanup

[jetstack-bot]

@inteon: Adding the "do-not-merge/release-note-label-needed" label because no release-note block was detected, please follow our release note process to remove it.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[jetstack-bot]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: inteon
To complete the pull request process, please assign irbekrm after the PR has been reviewed.
You can assign the PR to them by writing /assign @irbekrm in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

• OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[jetstack-bot]

Hi @inteon. Thanks for your PR.

I'm waiting for a jetstack or cert-manager member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[jakexks]

/ok-to-test

[wallrj]

@inteon Thanks for looking into this.
There are too many changes here to be merged at once.

Please start by creating a PR specifically for removing the Helm chart labels from the static manifests. (uncontroversial)

And another PR for setting default resource requests (needs discussion)

And although the Helm the components idea may simplify our Bazel build scripts, I do not think it is a good idea to provide such flexibility to our users.
How will we deal with support requests from people who may have installed an incompatible set of components?

[wallrj]

@inteon I found helm template --set installCRDs=true --show-only 'templates/crds.yaml' bazel-bin/deploy/charts/cert-manager/cert-manager.tgz.

Could that be used as a way to get only the CRDs without having to put any new logic into the templates?

The following issue is slightly related:

• helm template: show-only does not show files in crds directory helm/helm#9785

[inteon]

@inteon I found helm template --set installCRDs=true --show-only 'templates/crds.yaml' bazel-bin/deploy/charts/cert-manager/cert-manager.tgz.

Could that be used as a way to get only the CRDs without having to put any new logic into the templates?

The following issue is slightly related:

• helm template: show-only does not show files in crds directory helm/helm#9785

This cannot be used for helm install, if you look at the implementation, it basically does a regex search on the file name comments in the generated manifest (of all resources) and filters out the "show only" files.
So for the bazel generation, it can be used.
But this will not be possible:

helm install \
  cert-manager-crds jetstack/cert-manager \
  --set components={crd} \
  --version v1.4.0

helm install \
  cert-manager jetstack/cert-manager \
  --namespace cert-manager \
  --create-namespace \
  --version v1.4.0

Also, you cannot just install eg. webhook + cainjector + crds.
In my opinion, the components property would also be useful for the end-user. Please let me know in case you don't agree; in that case I'll change the logic to use the --show-only option.

[jetstack-bot]

@inteon: The following tests failed, say /retest to rerun all failed tests:

Test name	Commit	Details	Rerun command
pull-cert-manager-e2e-v1-21	0c82829	link	/test pull-cert-manager-e2e-v1-21
pull-cert-manager-bazel	0c82829	link	/test pull-cert-manager-bazel

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

[jetstack-bot]

@inteon: PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[inteon]

blocked on #4219 and #4209

[jetstack-bot]

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.
If this issue is safe to close now please do so with /close.
Send feedback to jetstack.
/lifecycle stale

[jetstack-bot]

Stale issues rot after 30d of inactivity.
Mark the issue as fresh with /remove-lifecycle rotten.
Rotten issues close after an additional 30d of inactivity.
If this issue is safe to close now please do so with /close.
Send feedback to jetstack.
/lifecycle rotten
/remove-lifecycle stale

[jetstack-bot]

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.
If this issue is safe to close now please do so with /close.
Send feedback to jetstack.
/lifecycle stale

[jetstack-bot]

Stale issues rot after 30d of inactivity.
Mark the issue as fresh with /remove-lifecycle rotten.
Rotten issues close after an additional 30d of inactivity.
If this issue is safe to close now please do so with /close.
Send feedback to jetstack.
/lifecycle rotten
/remove-lifecycle stale

[inteon]

/remove-lifecycle rotten

[jetstack-bot]

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.
If this issue is safe to close now please do so with /close.
Send feedback to jetstack.
/lifecycle stale

[inteon]

superseded by #4209 and #5362