Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix vscode crash #4200

Merged
merged 1 commit into from
Jul 10, 2021
Merged

Fix vscode crash #4200

merged 1 commit into from
Jul 10, 2021

Conversation

inteon
Copy link
Member

@inteon inteon commented Jul 9, 2021

What this PR does / why we need it:

On VS Code, when running ./hack/update-deps.sh, the git menu crashes because of the large amount of changed files.
VS Code tries to keep track of all file changes, the update script introduces a lot of changes and this causes the crash.
An easy fix is to add the vendor folder to the .gitignore file.

Which issue this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close that issue when PR gets merged): fixes #

Special notes for your reviewer:

Release note:

Signed-off-by: Inteon <42113979+inteon@users.noreply.github.com>
@jetstack-bot jetstack-bot added dco-signoff: yes Indicates that all commits in the pull request have the valid DCO sign-off message. do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. needs-kind Indicates a PR lacks a `kind/foo` label and requires one. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Jul 9, 2021
@jetstack-bot
Copy link
Contributor

Hi @inteon. Thanks for your PR.

I'm waiting for a jetstack or cert-manager member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@jetstack-bot jetstack-bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Jul 9, 2021
@jetstack-bot
Copy link
Contributor

@inteon: The label(s) kind/bugfix cannot be applied, because the repository doesn't have them.

In response to this:

/kind bugfix

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@jetstack-bot jetstack-bot added release-note-none Denotes a PR that doesn't merit a release note. kind/bug Categorizes issue or PR as related to a bug. and removed do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. needs-kind Indicates a PR lacks a `kind/foo` label and requires one. labels Jul 9, 2021
@irbekrm
Copy link
Contributor

irbekrm commented Jul 10, 2021

Makes sense as a change- do you know at which point the vendor got generated? I see we're removing it here

/ok-to-test

@jetstack-bot jetstack-bot added ok-to-test and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Jul 10, 2021
@inteon
Copy link
Member Author

inteon commented Jul 10, 2021

Makes sense as a change- do you know at which point the vendor got generated? I see we're removing it here

/ok-to-test

Interestingly, the vendor folder is created in the update-deps-licenses.sh script that is called by the ./hack/update-deps.sh script. Additionally, it seems like the update-deps-licenses.sh seems to be the slowest step when running the ./hack/update-deps.sh script.

@irbekrm
Copy link
Contributor

irbekrm commented Jul 10, 2021

Interestingly, the vendor folder is created in the update-deps-licenses.sh script

Ahh I see, we do go mod vendor there https://github.com/jetstack/cert-manager/blob/master/hack/update-deps-licenses.sh#L188 .
I guess it downloads and recurses all the deps which might take a long time.

/lgtm

@jetstack-bot jetstack-bot added the lgtm Indicates that a PR is ready to be merged. label Jul 10, 2021
@irbekrm
Copy link
Contributor

irbekrm commented Jul 10, 2021

/approve
/lgtm

@jetstack-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: inteon, irbekrm

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@jetstack-bot jetstack-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 10, 2021
@jetstack-bot jetstack-bot merged commit d1b02cd into cert-manager:master Jul 10, 2021
@jetstack-bot jetstack-bot added this to the v1.5 milestone Jul 10, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes Indicates that all commits in the pull request have the valid DCO sign-off message. kind/bug Categorizes issue or PR as related to a bug. lgtm Indicates that a PR is ready to be merged. ok-to-test release-note-none Denotes a PR that doesn't merit a release note. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants