-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add "components" Helm value #4219
Conversation
Hi @inteon. Thanks for your PR. I'm waiting for a jetstack or cert-manager member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/ok-to-test |
454033c
to
9c7b723
Compare
d5475d9
to
11131fd
Compare
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: inteon The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
d20aa95
to
6e67490
Compare
/test aws-tests |
@RinkiyaKeDad: The specified target(s) for
Use
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/test aws-tests-pre |
6e67490
to
ef7d37f
Compare
Signed-off-by: Inteon <42113979+inteon@users.noreply.github.com>
Signed-off-by: Inteon <42113979+inteon@users.noreply.github.com>
ef7d37f
to
1e4d27b
Compare
/test aws-tests-pre |
/test aws-tests-pre
…On Tue, 10 Aug, 2021, 6:59 pm jetstack-bot, ***@***.***> wrote:
@inteon <https://github.com/inteon>: The following test *failed*, say
/retest to rerun all failed tests:
Test name Commit Details Rerun command
aws-tests-pre 1e4d27b
<1e4d27b>
link
<https://prow.build-infra.jetstack.net/view/gs/jetstack-logs/pr-logs/pull/jetstack_cert-manager/4219/aws-tests-pre/1425085091561869313> /test
aws-tests-pre
Full PR test history
<https://prow.build-infra.jetstack.net/pr-history?org=jetstack&repo=cert-manager&pr=4219>.
Your PR dashboard <https://jetstack-build-infra.appspot.com/pr/inteon>.
Please help us cut down on flakes by linking to
<https://git.k8s.io/community/contributors/devel/sig-testing/flaky-tests.md#github-issues-for-known-flakes>
an open issue
<https://github.com/jetstack/cert-manager/issues?q=is:issue+is:open> when
you hit one in your PR.
Instructions for interacting with me using PR comments are available here
<https://git.k8s.io/community/contributors/guide/pull-requests.md>. If
you have questions or suggestions related to my behavior, please file an
issue against the kubernetes/test-infra
<https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:>
repository. I understand the commands that are listed here
<https://go.k8s.io/bot-commands>.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#4219 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ANSTBQGOAKHZBU4WMTATX43T4ESRZANCNFSM5AROJI6A>
.
|
/test aws-tests-pre |
3 similar comments
/test aws-tests-pre |
/test aws-tests-pre |
/test aws-tests-pre |
@inteon: The specified target(s) for
Use
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
@inteon: The following tests failed, say
Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
@inteon: PR needs rebase. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Issues go stale after 90d of inactivity. |
Stale issues rot after 30d of inactivity. |
Rotten issues close after 30d of inactivity. |
@jetstack-bot: Closed this PR. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
What this PR does / why we need it:
The helm value
components
is added, this value selects what resources should be included in the rendered helm chart.Now, we can render the CRDs with Helm too, this allows to install cert-manager in a custom namespace or use a custom release name. (Using the static CRDs as described here: https://cert-manager.io/docs/installation/helm/ will result in a failed install in both of those cases.)
$ helm template \ cert-manager jetstack/cert-manager \ --set components={crd} \ --version v1.4.0 | kubectl apply -f - $ helm install \ cert-manager jetstack/cert-manager \ --namespace cert-manager \ --create-namespace \ --version v1.4.0
The
installCRDs
helm value can be replaced bycomponents
. I added a deprecation warning notifying the chart user that this option might get removed in later releases.Which issue this PR fixes
Allows for installing cert-manager in namespace that differs from cert-manager, by creating 2 Helm deployments: #2752 (comment)
Should bring us closer to supporting a multi-controller scenario: #2525 (comment)
Release note: