Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add "components" Helm value #4219

Closed
wants to merge 2 commits into from
Closed

add "components" Helm value #4219

wants to merge 2 commits into from

Conversation

inteon
Copy link
Member

@inteon inteon commented Jul 17, 2021 •
edited
Loading

What this PR does / why we need it:
The helm value components is added, this value selects what resources should be included in the rendered helm chart.
Now, we can render the CRDs with Helm too, this allows to install cert-manager in a custom namespace or use a custom release name. (Using the static CRDs as described here: https://cert-manager.io/docs/installation/helm/ will result in a failed install in both of those cases.)

$ helm template \
  cert-manager jetstack/cert-manager \
  --set components={crd} \
  --version v1.4.0 | kubectl apply -f -

$ helm install \
  cert-manager jetstack/cert-manager \
  --namespace cert-manager \
  --create-namespace \
  --version v1.4.0

The installCRDs helm value can be replaced by components. I added a deprecation warning notifying the chart user that this option might get removed in later releases.

  • this can be used when generating static yaml manifests (bazel)
  • this can be used for automated testing (test for different install scenarios)

Which issue this PR fixes

Allows for installing cert-manager in namespace that differs from cert-manager, by creating 2 Helm deployments: #2752 (comment)

Should bring us closer to supporting a multi-controller scenario: #2525 (comment)

Release note:

add components selector in Helm values

@jetstack-bot jetstack-bot added release-note Denotes a PR that will be considered when it comes time to generate release notes. dco-signoff: yes Indicates that all commits in the pull request have the valid DCO sign-off message. needs-kind Indicates a PR lacks a `kind/foo` label and requires one. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Jul 17, 2021
@jetstack-bot
Copy link
Contributor

Hi @inteon. Thanks for your PR.

I'm waiting for a jetstack or cert-manager member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@jetstack-bot jetstack-bot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. area/deploy Indicates a PR modifies deployment configuration labels Jul 17, 2021
@jetstack-bot jetstack-bot added kind/feature Categorizes issue or PR as related to a new feature. and removed needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. needs-kind Indicates a PR lacks a `kind/foo` label and requires one. labels Jul 17, 2021
@SgtCoDFish
Copy link
Member

/ok-to-test

@jetstack-bot jetstack-bot added ok-to-test and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Jul 20, 2021
@inteon inteon mentioned this pull request Jul 29, 2021
Closed
@jetstack-bot jetstack-bot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Aug 3, 2021
@jetstack-bot jetstack-bot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Aug 10, 2021
@inteon inteon force-pushed the helm_components branch 2 times, most recently from d5475d9 to 11131fd Compare August 10, 2021 10:15
@jetstack-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: inteon
To complete the pull request process, please assign joshvanl after the PR has been reviewed.
You can assign the PR to them by writing /assign @joshvanl in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@inteon inteon force-pushed the helm_components branch 2 times, most recently from d20aa95 to 6e67490 Compare August 10, 2021 10:42
@RinkiyaKeDad
Copy link
Contributor

/test aws-tests

@jetstack-bot
Copy link
Contributor

@RinkiyaKeDad: The specified target(s) for /test were not found.
The following commands are available to trigger jobs:

  • /test pull-cert-manager-bazel
  • /test pull-cert-manager-bazel-experimental
  • /test pull-cert-manager-chart
  • /test pull-cert-manager-deps
  • /test pull-cert-manager-e2e-v1-16
  • /test pull-cert-manager-e2e-v1-17
  • /test pull-cert-manager-e2e-v1-18
  • /test pull-cert-manager-e2e-v1-19
  • /test pull-cert-manager-e2e-v1-20
  • /test pull-cert-manager-e2e-v1-21
  • /test pull-cert-manager-e2e-v1-21-feature-issuers-venafi-tpp
  • /test pull-cert-manager-e2e-v1-21-feature-issuers-venafi-cloud
  • /test pull-cert-manager-upgrade-v1-21
  • /test pull-cert-manager-e2e-v1-22

Use /test all to run the following jobs:

  • pull-cert-manager-bazel
  • pull-cert-manager-chart
  • pull-cert-manager-deps
  • pull-cert-manager-e2e-v1-21

In response to this:

/test aws-tests

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@RinkiyaKeDad
Copy link
Contributor

/test aws-tests-pre

@inteon
add components Helm value
ee70730 
Signed-off-by: Inteon <42113979+inteon@users.noreply.github.com>
@inteon
install crds separately
1e4d27b 
Signed-off-by: Inteon <42113979+inteon@users.noreply.github.com>
@RinkiyaKeDad
Copy link
Contributor

/test aws-tests-pre

@RinkiyaKeDad
Copy link
Contributor

RinkiyaKeDad commented Aug 10, 2021 via email

@RinkiyaKeDad
Copy link
Contributor

/test aws-tests-pre

3 similar comments
@RinkiyaKeDad
Copy link
Contributor

/test aws-tests-pre

@RinkiyaKeDad
Copy link
Contributor

/test aws-tests-pre

@RinkiyaKeDad
Copy link
Contributor

/test aws-tests-pre

@jetstack-bot
Copy link
Contributor

@inteon: The specified target(s) for /test were not found.
The following commands are available to trigger jobs:

  • /test pull-cert-manager-bazel
  • /test pull-cert-manager-bazel-experimental
  • /test pull-cert-manager-chart
  • /test pull-cert-manager-deps
  • /test pull-cert-manager-e2e-v1-16
  • /test pull-cert-manager-e2e-v1-17
  • /test pull-cert-manager-e2e-v1-18
  • /test pull-cert-manager-e2e-v1-19
  • /test pull-cert-manager-e2e-v1-20
  • /test pull-cert-manager-e2e-v1-21
  • /test pull-cert-manager-e2e-v1-22
  • /test pull-cert-manager-e2e-v1-22-feature-issuers-venafi-tpp
  • /test pull-cert-manager-e2e-v1-21-feature-issuers-venafi-cloud
  • /test pull-cert-manager-upgrade

Use /test all to run the following jobs:

  • pull-cert-manager-bazel
  • pull-cert-manager-chart
  • pull-cert-manager-deps
  • pull-cert-manager-e2e-v1-22

In response to this:

/test aws-tests-pre

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@jetstack-bot
Copy link
Contributor

@inteon: The following tests failed, say /retest to rerun all failed tests:

Test name Commit Details Rerun command
aws-tests-pre 1e4d27b link /test aws-tests-pre
pull-cert-manager-e2e-v1-22 1e4d27b link /test pull-cert-manager-e2e-v1-22

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@jetstack-bot
Copy link
Contributor

@inteon: PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@jetstack-bot jetstack-bot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Aug 18, 2021
@jetstack-bot
Copy link
Contributor

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.
If this issue is safe to close now please do so with /close.
Send feedback to jetstack.
/lifecycle stale

@jetstack-bot jetstack-bot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Nov 16, 2021
@jetstack-bot
Copy link
Contributor

Stale issues rot after 30d of inactivity.
Mark the issue as fresh with /remove-lifecycle rotten.
Rotten issues close after an additional 30d of inactivity.
If this issue is safe to close now please do so with /close.
Send feedback to jetstack.
/lifecycle rotten
/remove-lifecycle stale

@jetstack-bot jetstack-bot added lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. and removed lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. labels Dec 16, 2021
@jetstack-bot
Copy link
Contributor

Rotten issues close after 30d of inactivity.
Reopen the issue with /reopen.
Mark the issue as fresh with /remove-lifecycle rotten.
Send feedback to jetstack.
/close

@jetstack-bot
Copy link
Contributor

@jetstack-bot: Closed this PR.

In response to this:

Rotten issues close after 30d of inactivity.
Reopen the issue with /reopen.
Mark the issue as fresh with /remove-lifecycle rotten.
Send feedback to jetstack.
/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@inteon inteon mentioned this pull request Oct 27, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
area/deploy Indicates a PR modifies deployment configuration dco-signoff: yes Indicates that all commits in the pull request have the valid DCO sign-off message. kind/feature Categorizes issue or PR as related to a new feature. lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. ok-to-test release-note Denotes a PR that will be considered when it comes time to generate release notes. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@inteon @jetstack-bot @SgtCoDFish @RinkiyaKeDad