Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enabling serviceLabels for webhook service. #4260

Merged
merged 2 commits into from Jul 27, 2021
Merged

Enabling serviceLabels for webhook service. #4260

merged 2 commits into from Jul 27, 2021

Conversation

mozz-lx
Copy link
Contributor

@mozz-lx mozz-lx commented Jul 27, 2021 •
edited by irbekrm

Signed-off-by: Marco Ortega mortega@brightcove.com

What this PR does / why we need it:
My company the Kubernetes administrator enforces the resource labeling and I'm not able to install cert-manager using helm so this PR enables the option to add custom serviceLabels for the webhook service.

Special notes for your reviewer:
Hello @irbekrm, I closed the previous PR to add my signoff.

Allows to configure labels on cert-manager webhook service via a Helm value.

@mozz-lx
Enabling serviceLabels for webhook service.
feee2fd 
Signed-off-by: Marco Ortega <mortega@brightcove.com>
@jetstack-bot jetstack-bot added dco-signoff: yes Indicates that all commits in the pull request have the valid DCO sign-off message. area/deploy Indicates a PR modifies deployment configuration do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. needs-kind Indicates a PR lacks a `kind/foo` label and requires one. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Jul 27, 2021
@jetstack-bot
Copy link
Collaborator

Hi @mozz-lx. Thanks for your PR.

I'm waiting for a jetstack or cert-manager member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@jetstack-bot jetstack-bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Jul 27, 2021
@irbekrm
Copy link
Collaborator

irbekrm commented Jul 27, 2021

/ok-to-test

@jetstack-bot jetstack-bot added ok-to-test and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Jul 27, 2021
@irbekrm
Copy link
Collaborator

irbekrm commented Jul 27, 2021

Thank you for the PR!
This looks good, just one more minor thing - could we please also update the chart Readme with the new value https://github.com/jetstack/cert-manager/blob/master/deploy/charts/cert-manager/README.template.md#configuration?

@mozz-lx
Adding webhook.serviceLabels to README template
d525001 
Signed-off-by: Marco Ortega <mortega@brightcove.com>
@jetstack-bot jetstack-bot added release-note Denotes a PR that will be considered when it comes time to generate release notes. and removed do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. labels Jul 27, 2021
@irbekrm
Copy link
Collaborator

irbekrm commented Jul 27, 2021

Thanks for the contribution- this looks good to me!

/kind cleanup
/approve
/lgtm

@jetstack-bot jetstack-bot added kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lgtm Indicates that a PR is ready to be merged. and removed needs-kind Indicates a PR lacks a `kind/foo` label and requires one. labels Jul 27, 2021
@jetstack-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: irbekrm, mozz-lx

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@jetstack-bot jetstack-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 27, 2021
@irbekrm
Copy link
Collaborator

irbekrm commented Jul 27, 2021

flake
/test pull-cert-manager-bazel

@jetstack-bot jetstack-bot merged commit ed38011 into cert-manager:master Jul 27, 2021
@jetstack-bot jetstack-bot added this to the v1.5 milestone Jul 27, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@irbekrm irbekrm

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/deploy Indicates a PR modifies deployment configuration dco-signoff: yes Indicates that all commits in the pull request have the valid DCO sign-off message. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lgtm Indicates that a PR is ready to be merged. ok-to-test release-note Denotes a PR that will be considered when it comes time to generate release notes. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
v1.5
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@mozz-lx @jetstack-bot @irbekrm