Refactor this issuer to use issuer-lib #109
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
inteon
commented
May 26, 2023
inteon
force-pushed
the
use_issuer_lib
branch
2 times, most recently
from
a2cbd69
to
d72926c
Compare
inteon
force-pushed
the
use_issuer_lib
branch
from
d72926c
to
d875db5
Compare
inteon
force-pushed
the
use_issuer_lib
branch
2 times, most recently
from
40c52b3
to
baa16f4
Compare
SgtCoDFish
reviewed
Jan 8, 2024
There was a problem hiding this comment.
It doesn't look like the e2e test is running, which is really they key in evaluating whether this is safe or not.
IIRC it doesn't run on forks. Could you maybe re-create this PR from a branch on the jetstack/google-cas-issuer repo directly, which I think should trigger the E2E?
|
@SgtCoDFish I just had to add the |
Signed-off-by: Tim Ramlot <42113979+inteon@users.noreply.github.com>
SgtCoDFish
approved these changes
Jan 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the first open-source issuer that will start using this library.
This change greatly simplifies this issuer.