Ensures that namespace is hardcoded to jetstack-secure #104
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See helm/helm#3553 - helm template command does not properly interpolate namespace for namespaced resources
In general, I think we already had a discussion that we want to remove the install commands from this tool and keep it just for helper commands like retrieving creds, verifying cluster status etc
To verify that this works:
kind create clusterkubectl create namespace jetstack-securego run main.go operator deploy --auto-registry-credentialsfrom this branchjetstack-secureInstallationmanifest like https://github.com/jetstack/js-operator/blob/main/examples/installation.yaml with lines 18, 19 uncommented, verify that operator installed cert-manager as expected