-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support the restoring of issuers from backup files #70
Conversation
This command will be used prior to the install of a JS by operators to backup cluster state. Signed-off-by: Charlie Egan <charlieegan3@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for working on this Charlie!
I think the new flag looks good already for a first iteration. I've left a couple commands, most notably about distinguishing different issuer types that might not be backed up.
Additionally it'd be good if we printed out which issuers got restored (it kind of is obvious from Installation spec for us, but maybe not for someone less familiar with that CR).
We also don't parse any List types at all, but I think this is okay for now.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks Charlie, I've ran the new command and it looks good to me 👍🏼
/lgtm
Thanks for the feedback and for testing this out too. |
This allows the loading of cert-manager issuers and cluster issuers from a jsctl backup.
For example, with a backup.yaml as follows, the output for the installation will be as seen below. Note that the warnings of other issuers are logged to stderr in the process. In this case, a GoogleCASIssuer.