Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Latest operator #88

Merged
merged 4 commits into from
Feb 10, 2023
Merged

Latest operator #88

merged 4 commits into from
Feb 10, 2023

Conversation

irbekrm
Copy link
Contributor

@irbekrm irbekrm commented Feb 8, 2023 •
edited

This PR makes jsctl install latest published operator release and makes the required changes for that:

  • adds v0.0.1-alpha.20 operator manifests
  • removes v0.0.1-alpha.17 operator manifests
  • changes the format how image pull secret and registry are set in Installation spec (to match changes made in https://github.com/jetstack/js-operator/pull/303)
  • a couple linter error fixes, TODOs & more descriptive error messages

To test it:

1. Run `jsctl auth login`
2. Run `jsctl config set organization jetstack`
3. Run `jsctl clusters connect <some-cluster-name>` // observe that agent gets deployed
4. Run `go run main.go operator deploy --auto-registry-credentials` // from this PR
5. Observe that right operator version gets deployed
6. Run `go run main.go operator installations apply  --auto-registry-credentials --registry eu.gcr.io/jetstack-secure-enterprise`
7. Observe the correct Installation and image pull secret gets applied and eventually becomes ready

@irbekrm
Adds latest operator version, removes previous
a98e92c 
We cannot use both at the same time as they are not compatible

Signed-off-by: irbekrm <irbekrm@gmail.com>
@irbekrm
Updates Go deps
15afa24 
Signed-off-by: irbekrm <irbekrm@gmail.com>
@irbekrm
Fix a bunch of linter errors, make returned errors more descriptive
19f77bc 
Signed-off-by: irbekrm <irbekrm@gmail.com>
@irbekrm
Updates Installation generation to be compatible with latest operator…
7b8bfcd 
… version

Specifically to match how image pull secret & registry are configured on Installation spec

Signed-off-by: irbekrm <irbekrm@gmail.com>
@irbekrm irbekrm requested a review from inteon February 9, 2023 15:25
inteon
inteon approved these changes Feb 10, 2023
View reviewed changes
Copy link
Contributor

@inteon inteon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great improvements
/approve
/lgtm

@inteon inteon merged commit e07d6d8 into main Feb 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@inteon inteon inteon approved these changes

Assignees

@inteon inteon

Labels
lgtm size/XXL
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@irbekrm @inteon @jetstack-bot