Skip to content
This repository has been archived by the owner on Jan 9, 2023. It is now read-only.

Validate hub cluster contains all zones of multi-cluster #471

Merged
merged 1 commit into from Sep 10, 2018
Merged

Validate hub cluster contains all zones of multi-cluster #471

merged 1 commit into from Sep 10, 2018

Conversation

JoshVanL
Copy link
Contributor

@JoshVanL JoshVanL commented Aug 28, 2018 •
edited by simonswine

What this PR does / why we need it:
Validate all multi-cluster zones are also contained in hub subnets.

fixes #281

Validate configuration, so that hubs in multi cluster environments contain all zones of their clusters

/assign @simonswine

@jetstack-bot jetstack-bot added release-note-none Denotes a PR that doesn't merit a release note. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Aug 28, 2018
@jetstack-bot jetstack-bot added do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. dco-signoff: no Indicates that at least one commit in this pull request is missing the DCO sign-off message. and removed release-note-none Denotes a PR that doesn't merit a release note. labels Sep 10, 2018
@simonswine
Copy link
Contributor

/approve
/lgtm

/assign @JoshVanL
/unassign

@JoshVanL thanks this work well for me. Can you please add a release note and sort out the dco situation

@jetstack-bot jetstack-bot added the lgtm Indicates that a PR is ready to be merged. label Sep 10, 2018
@jetstack-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: simonswine

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@jetstack-bot jetstack-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 10, 2018
@JoshVanL
Validate hub cluster contains all zones of multi-cluster
0dd63ae 
Signed-off-by: JoshVanL <vleeuwenjoshua@gmail.com>
@jetstack-bot jetstack-bot added dco-signoff: yes Indicates that all commits in the pull request have the valid DCO sign-off message. release-note-none Denotes a PR that doesn't merit a release note. and removed lgtm Indicates that a PR is ready to be merged. dco-signoff: no Indicates that at least one commit in this pull request is missing the DCO sign-off message. do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. labels Sep 10, 2018
@JoshVanL
Copy link
Contributor Author

/unassign
/assign @simonswine

@jetstack-bot jetstack-bot assigned simonswine and unassigned JoshVanL Sep 10, 2018
@jetstack-bot jetstack-bot added release-note Denotes a PR that will be considered when it comes time to generate release notes. and removed release-note-none Denotes a PR that doesn't merit a release note. labels Sep 10, 2018
@simonswine
Copy link
Contributor

/lgtm

@jetstack-bot jetstack-bot added the lgtm Indicates that a PR is ready to be merged. label Sep 10, 2018
@jetstack-bot jetstack-bot merged commit 796d95d into jetstack:master Sep 10, 2018
@alljames alljames mentioned this pull request Nov 8, 2018
Closed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@wallrj wallrj Awaiting requested review from wallrj

Assignees

@simonswine simonswine

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes Indicates that all commits in the pull request have the valid DCO sign-off message. lgtm Indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Validate if all subnets of clusters are also contained in the hub
3 participants
@JoshVanL @simonswine @jetstack-bot