Skip to content
This repository has been archived by the owner on Jan 9, 2023. It is now read-only.

Adds AddListenrCertificates and RemoveListenerCertificates permissions #749

Merged
merged 1 commit into from Feb 19, 2019
Merged

Adds AddListenrCertificates and RemoveListenerCertificates permissions #749

merged 1 commit into from Feb 19, 2019

Conversation

JoshVanL
Copy link
Contributor

Adds "elasticloadbalancing:AddListenrCertificates" and "elasticloadbalancing:RemoveListenerCertificates" permissions to ELBs.

/assign @simonswine
fixes #479

Adds AddListenrCertificates and RemoveListenerCertificates permissions to elastic load balancing

@JoshVanL
Adds AddListenrCertificates and RemoveListenerCertificates permissions
4d7e2ac 
to ELB

Signed-off-by: JoshVanL <vleeuwenjoshua@gmail.com>
@jetstack-bot jetstack-bot added release-note Denotes a PR that will be considered when it comes time to generate release notes. dco-signoff: yes Indicates that all commits in the pull request have the valid DCO sign-off message. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Feb 19, 2019
@jetstack-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: JoshVanL

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@jetstack-bot jetstack-bot added approved Indicates a PR has been approved by an approver from all required OWNERS files. area/terraform Indicates a PR is affecting Terraform configuration labels Feb 19, 2019
@JoshVanL
Copy link
Contributor Author

/cc @BenCoughlan15

@jetstack-bot
Copy link
Collaborator

@JoshVanL: GitHub didn't allow me to request PR reviews from the following users: BenCoughlan15.

Note that only jetstack members and repo collaborators can review this PR, and authors cannot review their own PRs.

In response to this:

/cc @BenCoughlan15

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@JoshVanL JoshVanL mentioned this pull request Feb 19, 2019
Closed
@simonswine
Copy link
Contributor

/lgtm

@jetstack-bot jetstack-bot added the lgtm Indicates that a PR is ready to be merged. label Feb 19, 2019
@jetstack-bot jetstack-bot merged commit 2bbaf29 into jetstack:master Feb 19, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@simonswine simonswine Awaiting requested review from simonswine

Assignees

@simonswine simonswine

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/terraform Indicates a PR is affecting Terraform configuration dco-signoff: yes Indicates that all commits in the pull request have the valid DCO sign-off message. lgtm Indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Masters cannot attach certificates to ELBs
3 participants
@JoshVanL @jetstack-bot @simonswine