Skip to content
This repository has been archived by the owner on Apr 4, 2023. It is now read-only.

Terraform v0.12 support #53

Merged
merged 9 commits into from
Oct 16, 2019

Conversation

dippynark
Copy link
Contributor

Fork of #30 to address comments

@jetstack-bot jetstack-bot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. dco-signoff: yes Indicates that all commits in the pull request have the valid DCO sign-off message. labels Oct 15, 2019
@jetstack-bot jetstack-bot added needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. dco-signoff: no Indicates that at least one commit in this pull request is missing the DCO sign-off message. and removed dco-signoff: yes Indicates that all commits in the pull request have the valid DCO sign-off message. labels Oct 15, 2019
@jetstack-bot jetstack-bot added dco-signoff: yes Indicates that all commits in the pull request have the valid DCO sign-off message. and removed dco-signoff: no Indicates that at least one commit in this pull request is missing the DCO sign-off message. labels Oct 15, 2019
haysclark and others added 5 commits October 15, 2019 15:30
- performed 0.12upgrade and resolved various issues
- 1 TF-UPGRADE-TODO remains to be resolved

Signed-off-by: Hays Clark <hays.clark@gmail.com>
- removing TF-UPGRADE-TODO
- functionality verified locally

Signed-off-by: Hays Clark <hays.clark@gmail.com>
Signed-off-by: Luke Addison <luke.addison@jetstack.io>
Signed-off-by: Luke Addison <luke.addison@jetstack.io>
Signed-off-by: Luke Addison <luke.addison@jetstack.io>
@jetstack-bot jetstack-bot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Oct 15, 2019
@dippynark dippynark changed the title WIP: Terraform v0.12 support Terraform v0.12 support Oct 15, 2019
@jetstack-bot jetstack-bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Oct 15, 2019
Luke Addison added 4 commits October 15, 2019 15:38
Signed-off-by: Luke Addison <luke.addison@jetstack.io>
Signed-off-by: Luke Addison <luke.addison@jetstack.io>
Signed-off-by: Luke Addison <luke.addison@jetstack.io>
Signed-off-by: Luke Addison <luke.addison@jetstack.io>
@jetstack-bot jetstack-bot added dco-signoff: no Indicates that at least one commit in this pull request is missing the DCO sign-off message. and removed dco-signoff: yes Indicates that all commits in the pull request have the valid DCO sign-off message. labels Oct 15, 2019
@jetstack-bot jetstack-bot added dco-signoff: yes Indicates that all commits in the pull request have the valid DCO sign-off message. and removed dco-signoff: no Indicates that at least one commit in this pull request is missing the DCO sign-off message. labels Oct 15, 2019
@jetstack-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dippynark, wwwil

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@jetstack-bot jetstack-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 16, 2019
@wwwil
Copy link
Member

wwwil commented Oct 16, 2019

/lgtm

@jetstack-bot jetstack-bot added the lgtm Indicates that a PR is ready to be merged. label Oct 16, 2019
@jetstack-bot jetstack-bot merged commit 67d5537 into jetstack:master Oct 16, 2019
@repo-lockdown
Copy link

repo-lockdown bot commented Sep 3, 2020

This project is now deprecated so we aren't accepting any further changes.

@repo-lockdown repo-lockdown bot locked and limited conversation to collaborators Sep 3, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes Indicates that all commits in the pull request have the valid DCO sign-off message. lgtm Indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants