Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update cert-manager/csi-driver-spiffe test runners to use go v1.18 #667

Merged
merged 1 commit into from May 4, 2022
Merged

Update cert-manager/csi-driver-spiffe test runners to use go v1.18 #667

merged 1 commit into from May 4, 2022

Conversation

JoshVanL
Copy link
Contributor

@JoshVanL JoshVanL commented May 3, 2022

/assign @irbekrm

@jetstack-bot jetstack-bot added dco-signoff: yes Indicates that all commits in the pull request have the valid DCO sign-off message. area/cert-manager Indicates a PR related to cert-manager approved Indicates a PR has been approved by an approver from all required OWNERS files. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels May 3, 2022
@JoshVanL
Update cert-manager/csi-driver-spiffe test runners to use go v1.18
2d83124 
Signed-off-by: joshvanl <vleeuwenjoshua@gmail.com>
@BeckyPauley
Copy link
Contributor

/override pull-testing-check-testgrid-config

@jetstack-bot
Copy link
Collaborator

@BeckyPauley: Overrode contexts on behalf of BeckyPauley: pull-testing-check-testgrid-config

In response to this:

/override pull-testing-check-testgrid-config

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

irbekrm
irbekrm approved these changes May 3, 2022
View reviewed changes
Copy link
Contributor

@irbekrm irbekrm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@jetstack-bot jetstack-bot added the lgtm Indicates that a PR is ready to be merged. label May 3, 2022
@jetstack-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: irbekrm, JoshVanL

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@BeckyPauley
Copy link
Contributor

/override pull-testing-check-testgrid-config

@jetstack-bot
Copy link
Collaborator

@BeckyPauley: Overrode contexts on behalf of BeckyPauley: pull-testing-check-testgrid-config

In response to this:

/override pull-testing-check-testgrid-config

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@jetstack-bot jetstack-bot merged commit 424e256 into cert-manager:master May 4, 2022
@jetstack-bot
Copy link
Collaborator

@JoshVanL: Updated the job-config configmap in namespace default at cluster default using the following files:

  • key cert-manager-csi-driver-spiffe-presubmits.yaml using file config/jobs/cert-manager/csi-driver-spiffe/cert-manager-csi-driver-spiffe-presubmits.yaml

In response to this:

/assign @irbekrm

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@irbekrm irbekrm irbekrm approved these changes

Assignees

@irbekrm irbekrm

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/cert-manager Indicates a PR related to cert-manager dco-signoff: yes Indicates that all commits in the pull request have the valid DCO sign-off message. lgtm Indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@JoshVanL @BeckyPauley @jetstack-bot @irbekrm