Fix: Update secret template to support GHCR token #132
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
can confirm having the same issue |
wagnst
approved these changes
Nov 3, 2023
jwitko
changed the title
|
You might also want to adjust the first line of |
davidcollom
requested changes
Nov 8, 2023
There was a problem hiding this comment.
As @szpaczyna mentioned, there's a little more required... the if statement on line #1 of this file would need updating for the context of only providing a ghcr token and nothing else.
Sorry I missed this during the initial implementation 🤦
davidcollom
reviewed
Nov 14, 2023
| @@ -1,4 +1,4 @@ | |||
| {{- if or .Values.acr.refreshToken .Values.acr.username .Values.acr.password .Values.docker.token .Values.ecr.accessKeyID .Values.ecr.secretAccessKey .Values.ecr.sessionToken .Values.docker.username .Values.docker.password .Values.gcr.token .Values.quay.token (not (eq (len .Values.selfhosted) 0)) }} | |||
| {{- if or .Values.acr.refreshToken .Values.acr.username .Values.acr.password .Values.docker.token .Values.ecr.accessKeyID .Values.ecr.secretAccessKey .Values.ecr.sessionToken .Values.docker.username .Values.docker.password .Values.gcr.token .Values.ghcr.token .Values.quay.token (not (eq (len .Values.selfhosted) 0)) }} | |||
There was a problem hiding this comment.
nit: This should be reviewed to make some what simpler logic in the chart - maybe move this to a helper instead.
davidcollom
approved these changes
Nov 14, 2023
davidcollom
changed the title
|
Sorry @davidcollom , was at a conference last week and didn't see these comments. Thanks for merging and likely taking care of the extra stuff on your own. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes #124