Helm Chart: add imagePullSecret to serviceaccount #186
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
+1 |
davidcollom
approved these changes
May 15, 2024
|
Some Unit tests on the helm chart would have been good - https://github.com/jetstack/version-checker/blob/main/deploy/charts/version-checker/tests/serviceaccount_test.yaml But I can add them in follow up PR. Thanks for the contribution! 🎉 👍 |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In my work environment, we have have a local repository which does mirror and proxy external image repository for security reasons, it is essential to have imagePullSecrets added to the serviceaccount otherweise version-checker itself can not be pulled and started.