-
Notifications
You must be signed in to change notification settings - Fork 76
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add yaml deploy kustomization file #51
Conversation
Hi @rochacon. Thanks for your PR. I'm waiting for a jetstack member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Signed-off-by: Rodrigo Chacon <rochacon@gmail.com>
8d53b2f
to
dfba5eb
Compare
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: JoshVanL, rochacon The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Signed-off-by: Rodrigo Chacon <rochacon@gmail.com>
178c7c2
to
171e1c7
Compare
Thank you for the review @JoshVanL, I've pushed a new commit updating the README according to your comment. |
Awesome, cheers @rochacon 👍 /lgtm |
This adds a
kustomization.yaml
file to the static deploy, allowing the use of kustomize to apply manifest changes without the need to vendor the entire manifest, such as:Then use it with
kustomize build some/path/
orkubectl --kustomize ...
, e.g.,kubectl diff -k 'github.com/rochacon/version-checker/deploy/yaml?ref=kustomization'