Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add yaml deploy kustomization file #51

Merged
merged 2 commits into from
Sep 28, 2020

Conversation

rochacon
Copy link
Contributor

This adds a kustomization.yaml file to the static deploy, allowing the use of kustomize to apply manifest changes without the need to vendor the entire manifest, such as:

# some/path/kustomization.yaml
apiVersion: kustomize.config.k8s.io/v1beta1
kind: Kustomization
namespace: new  # this will patch the namespace of the resources
resources:
- github.com/jetstack/version-checker/deploy/yaml?ref=v0.3.0

Then use it with kustomize build some/path/ or kubectl --kustomize ..., e.g., kubectl diff -k 'github.com/rochacon/version-checker/deploy/yaml?ref=kustomization'

@jetstack-bot
Copy link
Contributor

Hi @rochacon. Thanks for your PR.

I'm waiting for a jetstack member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Signed-off-by: Rodrigo Chacon <rochacon@gmail.com>
@JoshVanL
Copy link
Contributor

Thanks @rochacon, can we update the README.md to reflect this change?
i.e.

$ cd ./deploy/yaml && kubectl apply -f .

to

$ kubectl apply -k ./deploy/yaml

/assign @rochacon
/approve

@jetstack-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: JoshVanL, rochacon

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Signed-off-by: Rodrigo Chacon <rochacon@gmail.com>
@rochacon
Copy link
Contributor Author

Thank you for the review @JoshVanL, I've pushed a new commit updating the README according to your comment.

@JoshVanL
Copy link
Contributor

Awesome, cheers @rochacon 👍

/lgtm
/ok-to-test

@jetstack-bot jetstack-bot merged commit e2f6281 into jetstack:master Sep 28, 2020
@rochacon rochacon deleted the kustomization branch September 28, 2020 16:26
@rochacon rochacon restored the kustomization branch September 28, 2020 16:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants