Better support for selfHosted and SSL connections #95
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
davidcollom
changed the title
davidcollom
force-pushed
the
enable-ssl-skip-verify
branch
2 times, most recently
from
c13d6a2
to
27d4a3a
Compare
davidcollom
force-pushed
the
enable-ssl-skip-verify
branch
from
27d4a3a
to
7cc8034
Compare
| } | ||
|
|
||
| if CAPath != "" { | ||
| certs, err := ioutil.ReadFile(CAPath) |
There was a problem hiding this comment.
The only thing that springs to mind here is how this RootCA could be rotated. Maybe this is "fine" for now? we might want to consider https://github.com/dyson/certman to ensure the tls config changes when the file does.
davidcollom
force-pushed
the
enable-ssl-skip-verify
branch
from
1e7c1e8
to
2d2d22a
Compare
davidcollom
added a commit
that referenced
this pull request
Jul 12, 2023
* Enable SSL Skip Verify if you're unable to provide a valid certificate bundle * Allow for additional Certs to be added into the CA Chain
davidcollom
added a commit
that referenced
this pull request
Jul 14, 2023
* Switching to Github Codeowners * Generate Codecoverage reports * Initial Build workflows * Upgrade to go1.18 * Fix Code Owners * Swith to ubuntu-latest * General fixes * Update to go 1.20 * Initial Dependabot setup * Upgrade all the things * Fix up testcoverage check * Switching to Go-lang/jwt * Only build the image if lint and tests pass * Simple Helm lint Test * Update Dockerfile to alpine:3.17.2 * helm chart fixes (#102) * Adding Error Counter Metric * Adding Semver Prefix and fix typo * Revert "helm chart fixes (#102)" (#103) This reverts commit 9185224. * Resolve issue 63 (#101) * Allow for overriding Token Path (#100) * Increase the number of Tags fetched for Docker Registries (#99) * Adding k8s.io support (#98) * Better support for selfHosted and SSL connections (#95) * Enable SSL Skip Verify if you're unable to provide a valid certificate bundle * Allow for additional Certs to be added into the CA Chain * Update README.md for helm installation * Adding initial release workflow * Build multi-arch images * Fix Dockerfile build artifact * Tag and Upload to quay.io/jetstack/version-checker instead of docker hub * Swithcing to main as the default branch changed * Set up for review * Switch to using sha for PR builds
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #92 and #72 - to be clear this is NOT a solution, only a work around, for the time being.