New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

RAdam fix for issue #96. #103

Merged

jettify merged 2 commits into jettify:master from bgnkim:master

Apr 18, 2020

Contributor

bgnkim commented Apr 16, 2020 •

edited

All checks were passed when I tested this in my computer, with CPU devices.
(PR for issue #96)

bgnkim added 2 commits

April 14, 2020 10:15


          Modify RAdam code to follow up the original RAdam repo:

7bc9628

- Different param groups should use different buffers.


          Wrap long code sequences to fit guidelines

75ee9ca

jettify approved these changes

View reviewed changes

Owner

jettify commented Apr 18, 2020

Thanks a lot!

jettify merged commit 2cfbf20 into jettify:master

jettify mentioned this pull request

RAdam: self._buffer should not be shared across param_groups #96

Closed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment